[v10.x] deps: backport ICU-20958 to fix CVE-2020-10531 #33572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Detected on NetBSD/amd64. Fixes: nodejs#29536 PR-URL: nodejs#29541 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: nodejs#32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
@richardlau I've merged the PR, so you can pull from unicode-org/icu@18b212f on the maint branch |
Add floating patch for ICU 64.2 from unicode-org/icu@18b212f. Original commit message: ICU-21032 Backport to 64.x: ICU-20958 Prevent SEGV_MAPERR in append See nodejs#971 (cherry picked from commit b7d08bc04a4296982fcef8b6b8a354a9e4e7afca) Refs: https://unicode-org.atlassian.net/browse/ICU-20958 Refs: unicode-org/icu#1155
BethGriggs
approved these changes
May 28, 2020
|
Landed in bd78c6e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add floating patch for ICU 64.2 from unicode-org/icu@18b212f.
Original commit message:
Refs: https://unicode-org.atlassian.net/browse/ICU-20958
Refs: unicode-org/icu#1155
Refs: nodejs/help#2716
I don't have a way of reproducing the crash for the original ICU CVE on
v10.xas the version of V8 included does not contain theIntl.ListFormatfunction.
cc @nodejs/lts @srl295
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes