Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.x backport] module: package "exports" error refinements #32287

Closed
wants to merge 1 commit into from
Closed

[12.x backport] module: package "exports" error refinements #32287

wants to merge 1 commit into from

Conversation

guybedford
Copy link
Contributor

Backports the PR from #31625.

//cc @codebytere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core. v12.x labels Mar 15, 2020
@guybedford guybedford mentioned this pull request Mar 15, 2020
Closed
4 tasks
@guybedford guybedford force-pushed the 12-module-refinements branch from f577233 to 1e36c5a Compare March 18, 2020 18:57
ljharb
ljharb reviewed Mar 23, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending comment

lib/internal/errors.js Show resolved Hide resolved
@MylesBorins MylesBorins mentioned this pull request Mar 23, 2020
Closed
@guybedford guybedford force-pushed the 12-module-refinements branch from 1e36c5a to 7dd15fd Compare March 29, 2020 15:27
@codebytere codebytere force-pushed the v12.x-staging branch 2 times, most recently from 63a03d2 to d577190 Compare March 31, 2020 23:57
@codebytere
Copy link
Member

@guybedford staging should be good to rebase against, then we can get this landed.

@guybedford
module: package "exports" error refinements
03a28dd 
PR-URL: nodejs#31625
Reviewed-By: Jan Krems <jan.krems@gmail.com>
@guybedford guybedford force-pushed the 12-module-refinements branch from 7dd15fd to 03a28dd Compare April 1, 2020 02:34
@guybedford
Copy link
Contributor Author

Thanks @codebytere for the ping, I've done a fresh rebase.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30351/

@MylesBorins
Copy link
Contributor

this lands cleanly on v12.x-staging without needing backport. Closing

@MylesBorins MylesBorins closed this Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins left review comments

@ljharb ljharb ljharb left review comments

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guybedford @codebytere @nodejs-github-bot @MylesBorins @ljharb @GeoffreyBooth