Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace var with let in test/parallel/test-whatwg-url-toascii.js #30378

Closed
wants to merge 1 commit into from
Closed

test: replace var with let in test/parallel/test-whatwg-url-toascii.js #30378

wants to merge 1 commit into from

Conversation

Vunovati
Copy link
Contributor

Checklist
  • [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • [ x] commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 12, 2019
Trott
Trott requested changes Nov 12, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are copied from WPT and should not be modified.

@Trott
Copy link
Member

Trott commented Nov 12, 2019

Hi, @Vunovati! Welcome and thanks for the pull request. I'm guessing this is a Code + Learn task. Unfortunately, you may have been given a task that should not be done. Tests that are copied from WPT should not be modified.

@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
@Trott
Copy link
Member

Trott commented Nov 12, 2019

@cjihrig @jasnell We do not alter tests copied from WPT. See comment on line 18. I recommend closing this and assigning a different task to the attendee.

@cjihrig
Copy link
Contributor

cjihrig commented Nov 12, 2019

@Trott, agreed. Sorry, I only quickly looked at the diff amid the flood of C&L PRs.

I think I might have said this in the past, but it would be nice for the WPT tests to be more isolated from the rest of our test suite.

@trivikr trivikr mentioned this pull request Nov 13, 2019
Closed
2 tasks
@BridgeAR
Copy link
Member

I am closing this PR due to mentioned reason above.

@Vunovati I am very sorry, this task should not have been in the list. Please feel free to open another PR by checking the list again. Again, I am very sorry that this PR can not land as such.

@BridgeAR BridgeAR closed this Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott requested changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Vunovati @Trott @cjihrig @BridgeAR @jasnell @nodejs-github-bot