Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: patch V8 to 7.7.299.11 #29628

Closed
wants to merge 1 commit into from
Closed

deps: patch V8 to 7.7.299.11 #29628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 7
#define V8_MINOR_VERSION 7
#define V8_BUILD_NUMBER 299
#define V8_PATCH_LEVEL 10
#define V8_PATCH_LEVEL 11

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/inspector/custom-preview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,10 @@ void bodyCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
} // anonymous namespace

void generateCustomPreview(int sessionId, const String16& groupName,
v8::Local<v8::Context> context,
v8::Local<v8::Object> object,
v8::MaybeLocal<v8::Value> maybeConfig, int maxDepth,
std::unique_ptr<CustomPreview>* preview) {
v8::Local<v8::Context> context = object->CreationContext();
v8::Isolate* isolate = context->GetIsolate();
v8::MicrotasksScope microtasksScope(isolate,
v8::MicrotasksScope::kDoNotRunMicrotasks);
Expand Down
6 changes: 3 additions & 3 deletions deps/v8/src/inspector/custom-preview.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ namespace v8_inspector {
const int kMaxCustomPreviewDepth = 20;

void generateCustomPreview(
int sessionId, const String16& groupName, v8::Local<v8::Context> context,
v8::Local<v8::Object> object, v8::MaybeLocal<v8::Value> config,
int maxDepth, std::unique_ptr<protocol::Runtime::CustomPreview>* preview);
int sessionId, const String16& groupName, v8::Local<v8::Object> object,
v8::MaybeLocal<v8::Value> config, int maxDepth,
std::unique_ptr<protocol::Runtime::CustomPreview>* preview);

} // namespace v8_inspector

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/inspector/injected-script.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ Response InjectedScript::wrapObjectMirror(
if (!response.isSuccess()) return response;
if (customPreviewEnabled && value->IsObject()) {
std::unique_ptr<protocol::Runtime::CustomPreview> customPreview;
generateCustomPreview(sessionId, groupName, context, value.As<v8::Object>(),
generateCustomPreview(sessionId, groupName, value.As<v8::Object>(),
customPreviewConfig, maxCustomPreviewDepth,
&customPreview);
if (customPreview) (*result)->setCustomPreview(std::move(customPreview));
Expand Down