Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gyp to node-gyp@v5.0.3 #29129

Closed
wants to merge 1 commit into from

Conversation

sam-github
Copy link
Contributor

Process:

cd tools
rm -rf gyp
git clone git@github.com:nodejs/node-gyp.git
(cd node-gyp && git checkout v5.0.3)
mv node-gyp/gyp .
rm -rf node-gyp
git add -A gyp

Fixes: #28555

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Process:

  cd tools
  rm -rf gyp
  git clone git@github.com:nodejs/node-gyp.git
  (cd node-gyp && git checkout v5.0.3)
  mv node-gyp/gyp .
  rm -rf node-gyp
  git add -A gyp
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Aug 14, 2019
@sam-github
Copy link
Contributor Author

NOTE The commit message describes exactly what I did.

#28555 is the discussion of whether this is even a good idea.

I don't know if this drops changes, or if all our local changes were upstreamed. That will have to be checked, but I'm not sure I have the relevant context or knowlege to evaluate that, so consider this a WIP, perhaps?

@bnoordhuis
Copy link
Member

I don't know if this drops changes, or if all our local changes were upstreamed.

It does and they weren't. :-(

@Trott
Copy link
Member

Trott commented Aug 17, 2019

I don't know if this drops changes, or if all our local changes were upstreamed.

It does and they weren't. :-(

Does it make sense to close this and open a fresh PR to upgrade or keep working on this one?

@sam-github
Copy link
Contributor Author

I'll close, we still need a plan, and it'll be more complicated than this.

@sam-github sam-github closed this Aug 17, 2019
@sam-github sam-github deleted the update-gyp-to-v5.0.3 branch October 9, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-vendor node/node-gyp --> tools/gyp/
4 participants