Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: handle errors while printing error objects #25834

Closed
wants to merge 1 commit into from
Closed

src: handle errors while printing error objects #25834

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Handle situations where accessing .name or .stack on an object
fails.

Fixes: #25718

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
src: handle errors while printing error objects
2e2b276 
Handle situations where accessing `.name` or `.stack` on an object
fails.

Fixes: nodejs#25718
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2460/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2019
@addaleax
Copy link
Member Author

addaleax commented Feb 1, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20529/

@addaleax
Copy link
Member Author

addaleax commented Feb 3, 2019

Landed in f722540

@addaleax addaleax closed this Feb 3, 2019
@addaleax addaleax deleted the errors-maybe branch February 3, 2019 19:39
addaleax added a commit that referenced this pull request Feb 3, 2019
@addaleax
src: handle errors while printing error objects
f722540 
Handle situations where accessing `.name` or `.stack` on an object
fails.

Fixes: #25718

PR-URL: #25834
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this pull request Feb 3, 2019
@addaleax
src: handle errors while printing error objects
84358b5 
Handle situations where accessing `.name` or `.stack` on an object
fails.

Fixes: #25718

PR-URL: #25834
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jdalton
Copy link
Member

jdalton commented Feb 7, 2019

Nice @addaleax!

I was just going to report this as:

echo "var e = new Error;Reflect.defineProperty(e,'stack', { get() { throw new Error } });throw e" | node

could cause a hard crash. I believe this PR fixed it since I do not hit the issue when I build from master.

@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@Fishrock123 Fishrock123 mentioned this pull request Mar 18, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FatalException handler SIGABRT from throw with .stack getter error
8 participants
@addaleax @nodejs-github-bot @jdalton @Fishrock123 @targos @cjihrig @JungMinu @devsnek