Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove string literal from strictEqual() #22512

Closed
wants to merge 1 commit into from
Closed

test: remove string literal from strictEqual() #22512

wants to merge 1 commit into from

Conversation

ScottyVG
Copy link
Contributor

…st-stream2-writable.js to allow for debugging to work properly

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ScottyVG
remove 3rd argument from assert.deepStrictEqual() in test/parallel/te…
27f7798 
…st-stream2-writable.js to allow for debugging to work properly
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 24, 2018
addaleax
addaleax approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

If you want, have a look at the commit message guidelines, but that can also be taken care of when merging this.

@Trott
Copy link
Member

Trott commented Aug 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16748/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2018
@ScottyVG ScottyVG changed the title remove 3rd argument from assert.deepStrictEqual() in test/parallel/te… test: remove string literal from strictEqual() Aug 25, 2018
@gdams
Copy link
Member

gdams commented Aug 27, 2018 •
edited
Loading

landed in: 31b3273. Thanks for the fix @ScottyVG!

@gdams gdams closed this Aug 27, 2018
gdams pushed a commit that referenced this pull request Aug 27, 2018
@ScottyVG
test: remove string literal from strictEqual()
31b3273 
Remove 3rd argument from assert.deepStrictEqual() in
test/parallel/test-stream2-writable.js to allow for debugging to work
properly.

PR-URL: #22512
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
addaleax pushed a commit that referenced this pull request Aug 27, 2018
@ScottyVG @addaleax
test: remove string literal from strictEqual()
303d2e6 
Remove 3rd argument from assert.deepStrictEqual() in
test/parallel/test-stream2-writable.js to allow for debugging to work
properly.

PR-URL: #22512
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@Trott
Copy link
Member

Trott commented Aug 28, 2018

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

targos pushed a commit that referenced this pull request Sep 3, 2018
@ScottyVG @targos
test: remove string literal from strictEqual()
7f85288 
Remove 3rd argument from assert.deepStrictEqual() in
test/parallel/test-stream2-writable.js to allow for debugging to work
properly.

PR-URL: #22512
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@ScottyVG @targos
test: remove string literal from strictEqual()
9ac6530 
Remove 3rd argument from assert.deepStrictEqual() in
test/parallel/test-stream2-writable.js to allow for debugging to work
properly.

PR-URL: #22512
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ScottyVG @Trott @gdams @jasnell @addaleax @lpinca @cjihrig @trivikr @nodejs-github-bot