test: remove harmony flags #22285
Closed
test: remove harmony flags #22285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
reviewed
Aug 12, 2018
| @@ -1,7 +1,5 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Flags: --harmony-bigint | |||
There was a problem hiding this comment.
this entire file should be put into test-util-inspect.js
jasnell
approved these changes
Aug 12, 2018
|
Trivial enough to fast-track, I think... with or without moving into Please 👍 to approve fast-track. |
|
The flag |
addaleax
approved these changes
Aug 12, 2018
v8 6.8 supports all removed flags. For example for BigInt.
devsnek
reviewed
Aug 13, 2018
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Flags: --experimental-vm-modules --harmony-import-meta | |||
| @@ -1,6 +1,6 @@ | |||
| 'use strict'; | |||
|
|
|||
| // Flags: --experimental-vm-modules --experimental-modules --harmony-dynamic-import | |||
3672def to
0450484
Compare
|
I went ahead and removed all harmony flags that v8 supports out of the box and updated the commit message accordingly. |
trivikr
approved these changes
Aug 13, 2018
trivikr
approved these changes
Aug 13, 2018
lpinca
approved these changes
Aug 13, 2018
|
Resume build: https://ci.nodejs.org/job/node-test-pull-request/16441/ ✔️ |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Aug 15, 2018
v8 6.8 supports all removed flags. For example for BigInt. PR-URL: nodejs#22285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 525544b 🎉 |
|
Edit: the conflict was related to a semver-major change and trivial to fix. |
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
v8 6.8 supports all removed flags. For example for BigInt. PR-URL: #22285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
v8 6.8 supports all removed flags. For example for BigInt. PR-URL: #22285 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 supports BigInt and this can now be removed.
Update: I went ahead and removed all harmony flags where v8 supports it out of the box.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes