test: remove common.hasTracing #22250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengl
approved these changes
Aug 10, 2018
jasnell
reviewed
Aug 10, 2018
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| const common = require('../common'); | |||
|
|
|||
| if (!common.hasTracing) | |||
| if (!process.binding('config').hasTracing) | |||
There was a problem hiding this comment.
This could likely be modified to simply attempt to require('trace_events'), which will throw if tracing is not enabled...
let trace_events;
try {
trace_events = require('trace_events');
} catch (err) {
common.skip('missing trace events');
}
// ...There was a problem hiding this comment.
I don't oppose such a modification, but if given the choice, I'd prefer to keep this a simple migrate-the-existing-thing-into-the-one-test-that-uses-it and have any modifications to the-existing-thing happen in a subsequent PR.
|
Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16355/ |
richardlau
approved these changes
Aug 10, 2018
`common.hasTracing` is only used in one place. `common` is bloated so let's move that to the one test that uses it. `hasTracing` is undocumented so there's no need to remove it from the README file as it's not there in the first place. Similarly, it's not included in the .mjs version of the `common` file.
90aeaa4 to
fd39bbb
Compare
cjihrig
approved these changes
Aug 11, 2018
trivikr
approved these changes
Aug 12, 2018
gdams
approved these changes
Aug 12, 2018
lpinca
approved these changes
Aug 12, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 14, 2018
`common.hasTracing` is only used in one place. `common` is bloated so let's move that to the one test that uses it. `hasTracing` is undocumented so there's no need to remove it from the README file as it's not there in the first place. Similarly, it's not included in the .mjs version of the `common` file. PR-URL: nodejs#22250 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in c75c917 |
targos
pushed a commit
that referenced
this pull request
Aug 19, 2018
`common.hasTracing` is only used in one place. `common` is bloated so let's move that to the one test that uses it. `hasTracing` is undocumented so there's no need to remove it from the README file as it's not there in the first place. Similarly, it's not included in the .mjs version of the `common` file. PR-URL: #22250 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
`common.hasTracing` is only used in one place. `common` is bloated so let's move that to the one test that uses it. `hasTracing` is undocumented so there's no need to remove it from the README file as it's not there in the first place. Similarly, it's not included in the .mjs version of the `common` file. PR-URL: #22250 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: George Adams <george.adams@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.hasTracingis only used in one place.commonis bloated solet's move that to the one test that uses it.
hasTracingis undocumented to there's no need to remove it from theREADME file as it's not there in the first place.
Similarly, it's not included in the .mjs version of the
commonfile.@nodejs/testing
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes