Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: extract validateNumber validator #22249

Closed
wants to merge 1 commit into from
Closed

lib: extract validateNumber validator #22249

wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

Pulls out another common argument validator to internal/validators

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@maclover7
lib: extract validateNumber validator
656027e 
Pulls out another common argument validator to `internal/validators`
@nodejs-github-bot
Copy link
Collaborator

@maclover7 build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/505/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 10, 2018
@maclover7
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16359/

@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

Resumed build: https://ci.nodejs.org/job/node-test-pull-request/16378/

@maclover7
Copy link
Contributor Author

Resume Build: https://ci.nodejs.org/job/node-test-pull-request/16437/

@trivikr
Copy link
Member

trivikr commented Aug 14, 2018

Resume build: https://ci.nodejs.org/job/node-test-pull-request/16440/

@maclover7
Copy link
Contributor Author

Re node-test-commit-linux failures, alpine-latest-x64 is a known infrastructure flake and test.async-hooks/test-callback-error failing on fedora-latest-x64 is a known flaky test being tracked at #15985. Since all failures are non specific to this PR, going to go ahead and land this.

@maclover7 maclover7 closed this Aug 14, 2018
@maclover7
Copy link
Contributor Author

Landed in 3e44b8c

@maclover7 maclover7 deleted the jm-validatenumber branch August 14, 2018 15:35
maclover7 added a commit that referenced this pull request Aug 14, 2018
@maclover7
lib: extract validateNumber validator
3e44b8c 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@joyeecheung joyeecheung mentioned this pull request Aug 15, 2018
Closed
@targos
Copy link
Member

targos commented Aug 19, 2018

Should this be backported to v10.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

targos pushed a commit that referenced this pull request Aug 24, 2018
@maclover7 @targos
lib: extract validateNumber validator
29a5efa 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
@maclover7 @targos
lib: extract validateNumber validator
1eac11f 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
@maclover7 @targos
lib: extract validateNumber validator
f0153d0 
Pulls out another common argument validator to `internal/validators`

PR-URL: #22249
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Sep 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bengl bengl bengl approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@maclover7 @nodejs-github-bot @trivikr @targos @bengl @jasnell @cjihrig @richardlau