doc: update iojs.1 for man page #2204
Conversation
| --es_staging (enable all completed harmony features) | ||
| type: bool default: false | ||
| --harmony (enable all completed harmony features) | ||
| type: bool default: false | ||
| --harmony_shipping (enable all shipped harmony features) | ||
| --harmony_shipping (enable all shipped harmony fetaures) | ||
| type: bool default: true |
|
@Trott Thanks. I will fix. these options are generated by v8... I will try to report or pull request to v8. |
|
@yosuke-furukawa I already did a CL about that a while ago. |
|
LGTM btw |
| @@ -60,6 +60,9 @@ and servers. | |||
|
|
|||
| --throw-deprecation throw errors on deprecations | |||
|
|
|||
| --trace-sync-io show stack trace when use of sync IO | |||
|
Had been meaning to do this. LGTM otherwise. |
|
Had been meaning to do this also. LGTM minus the comment |
|
@yosuke-furukawa LGTM :) |
| --concurrent_sweeping (use concurrent sweeping) | ||
| type: bool default: true | ||
| --trace_incremental_marking (trace progress of the incremental marking) | ||
| type: bool default: false | ||
| --track_gc_object_stats (track object counts and memory usage) | ||
| type: bool default: false | ||
| --track_detached_contexts (track native contexts that are expected to be garbage collected) | ||
| type: bool default: true | ||
| --trace_detached_contexts (trace native contexts that are expected to be garbage collected) |
There was a problem hiding this comment.
Listed twice with different default values.
There was a problem hiding this comment.
ooops, this is also v8 document mistake....
|
fixed! PTAL @thefourtheye |
| @@ -533,12 +556,18 @@ If set to 1 then colors will not be used in the REPL. | |||
| type: bool default: true | |||
| --incremental_marking_steps (do incremental marking steps) | |||
| type: bool default: true | |||
| --overapproximate_weak_closure (overapproximate weak closer to reduce atomic pause time) | |||
There was a problem hiding this comment.
overapproximate weak closer or overapproximate weak closure?
|
@yosuke-furukawa Sorry, I couldn't complete the review the other day. I left two more comments now. PTAL. LGTM 👍 |
|
I wouldn't worry about reviewing the v8 options too much. They'll probably just be overwritten in the future anyways. |
|
Yes, I agree @Fishrock123 . I just output these options using https://github.com/v8/v8-git-mirror/blob/master/src/flag-definitions.h#L635-L636 |
|
LGTM @yosuke-furukawa I guess you can land it after an rebase. |
|
@silverwind Thank you! |
|
Looks like the |
|
I feel this man page should be generated automatically. I will close this and I will send another PR ASAP. |
I checked
man iojsbut some options are missing like (--trace-sync-io, --strong_mode).so I just updated
iojs.1.