Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] deps: V8: cherry-pick 8361fa58 from upstream #21294

Merged
merged 1 commit into from
Jun 30, 2018
Merged

[8.x] deps: V8: cherry-pick 8361fa58 from upstream #21294

merged 1 commit into from
Jun 30, 2018

Conversation

ofrobots
Copy link
Contributor

9.x: #21293

Original commit message:

[runtime] Fix derived class instantiation

Bug: chromium:806388
Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c
Reviewed-on: https://chromium-review.googlesource.com/894942
Reviewed-by: Igor Sheludko ishell@chromium.org
Commit-Queue: Camillo Bruni cbruni@chromium.org
Cr-Commit-Position: refs/heads/master@{#50990}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @nodejs/v8-update

@nodejs-github-bot
Copy link
Collaborator

@ofrobots sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added v8 engine Issues and PRs related to the V8 dependency. v8.x labels Jun 12, 2018
@ofrobots ofrobots mentioned this pull request Jun 12, 2018
Closed
2 tasks
@MylesBorins
Copy link
Contributor

this is going to need a rebase and another CI kick off

@ofrobots ofrobots force-pushed the backport/8/806388 branch from fa01875 to 2a47c7d Compare June 14, 2018 21:39
@ofrobots
Copy link
Contributor Author

Rebased.

New CI: https://ci.nodejs.org/job/node-test-pull-request/15469/
New V8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1426/

@ofrobots ofrobots requested a review from targos June 14, 2018 21:41
@ofrobots
Copy link
Contributor Author

@mhdawson the V8-CI seems to be failing on ppcle and s390x. Any ideas why?

@ofrobots
Copy link
Contributor Author

@nodejs/build @mhdawson ping on the V8-CI issues above.

@mhdawson
Copy link
Member

I fixed the s390 issue a few days ago as mentioned on the other PR.

@ofrobots ofrobots added blocked PRs that are blocked by other issues or PRs. and removed blocked PRs that are blocked by other issues or PRs. labels Jun 28, 2018
@ofrobots
Copy link
Contributor Author

Fresh V8 CI now that the CI issues are fixed: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1495/

@ofrobots
Copy link
Contributor Author

@nodejs/lts @nodejs/v8-update this needs an LGTM before this back-port can land.

MylesBorins
MylesBorins approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@ofrobots
deps: V8: cherry-pick 8361fa58 from upstream
a075cbe 
Original commit message:
  [runtime] Fix derived class instantiation

  Bug: chromium:806388
  Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c
  Reviewed-on: https://chromium-review.googlesource.com/894942
  Reviewed-by: Igor Sheludko <ishell@chromium.org>
  Commit-Queue: Camillo Bruni <cbruni@chromium.org>
  Cr-Commit-Position: refs/heads/master@{nodejs#50990}

PR-URL: nodejs#21294
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@ofrobots ofrobots force-pushed the backport/8/806388 branch from 2a47c7d to a075cbe Compare June 30, 2018 15:55
@ofrobots ofrobots merged commit a075cbe into nodejs:v8.x-staging Jun 30, 2018
@ofrobots
Copy link
Contributor Author

Thanks!. Landed on v8.x-staging as a075cbe.

@ofrobots ofrobots deleted the backport/8/806388 branch June 30, 2018 15:56
@MylesBorins MylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@ofrobots @rvagg
deps: V8: cherry-pick 8361fa58 from upstream
9aeffab 
Original commit message:
  [runtime] Fix derived class instantiation

  Bug: chromium:806388
  Change-Id: Ieb343f0d532c16b6102e85222b77713f23bacf8c
  Reviewed-on: https://chromium-review.googlesource.com/894942
  Reviewed-by: Igor Sheludko <ishell@chromium.org>
  Commit-Queue: Camillo Bruni <cbruni@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#50990}

PR-URL: #21294
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@targos targos Awaiting requested review from targos

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ofrobots @nodejs-github-bot @MylesBorins @mhdawson