Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: updates crypto doc with openssl list -cipher-algorithms #20502

Closed
wants to merge 2 commits into from
Closed

doc: updates crypto doc with openssl list -cipher-algorithms #20502

wants to merge 2 commits into from

Conversation

shobhitchittora
Copy link
Contributor

@shobhitchittora shobhitchittora commented May 3, 2018 •
edited
Loading

Closes: #20501
Refs: #20385

  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels May 3, 2018
vsemozhetbyt
vsemozhetbyt reviewed May 3, 2018
View reviewed changes
doc/api/crypto.md Outdated
@@ -1496,8 +1498,9 @@ option is not required but can be used to restrict accepted authentication tags
to those with the specified length.

The `algorithm` is dependent on OpenSSL, examples are `'aes192'`, etc. On
recent OpenSSL releases, `openssl list-cipher-algorithms` will display the
available cipher algorithms.
recent OpenSSL releases, `openssl list -cipher-algorithms`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after the comma)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

vsemozhetbyt
vsemozhetbyt reviewed May 3, 2018
View reviewed changes
doc/api/crypto.md Outdated
recent OpenSSL releases, `openssl list-cipher-algorithms` will display the
available cipher algorithms.
recent OpenSSL releases, `openssl list -cipher-algorithms`
(`openssl list-cipher-algorithms` for older versions of OpenSSL) will
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt May 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after the backtick here and in two other same lines)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@shobhitchittora shobhitchittora force-pushed the update-doc-openssl-list-cipher branch from dfa96c0 to 36ab254 Compare May 3, 2018 15:20
@shobhitchittora shobhitchittora force-pushed the update-doc-openssl-list-cipher branch from 36ab254 to 36beaf4 Compare May 3, 2018 15:21
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/656/

cc @nodejs/crypto

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label May 3, 2018
@mscdex
Copy link
Contributor

mscdex commented May 3, 2018 •
edited
Loading

Either an appropriate issue should be referenced instead of #20501 or it should just be left out entirely. There is no need to create an issue just for the PR.

@mscdex
Copy link
Contributor

mscdex commented May 3, 2018

Also, 'cypher' in the commit message should be 'cipher'

@shobhitchittora shobhitchittora changed the title doc: updates crypto doc with openssl list -cypher-algorithms doc: updates crypto doc with openssl list -cipher-algorithms May 3, 2018
@shobhitchittora
Copy link
Contributor Author

@vsemozhetbyt can you please update the commit message (cypher to cipher) while landing.
@mscdex my bad! 😅

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 4, 2018
@addaleax
Copy link
Member

addaleax commented May 6, 2018

Landed in a1f342f 🎉

@addaleax addaleax closed this May 6, 2018
addaleax pushed a commit that referenced this pull request May 6, 2018
@shobhitchittora @addaleax
doc: updates crypto doc with openssl list -cipher-algorithms
a1f342f 
PR-URL: #20502
Refs: #20385
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@shobhitchittora @MylesBorins
doc: updates crypto doc with openssl list -cipher-algorithms
31dfb0a 
PR-URL: #20502
Refs: #20385
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 8, 2018
@shobhitchittora @MylesBorins
doc: updates crypto doc with openssl list -cipher-algorithms
e362e06 
PR-URL: #20502
Refs: #20385
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request May 9, 2018
@shobhitchittora @MylesBorins
doc: updates crypto doc with openssl list -cipher-algorithms
8bd45d8 
PR-URL: #20502
Refs: #20385
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsemozhetbyt vsemozhetbyt vsemozhetbyt left review comments

@trivikr trivikr trivikr approved these changes

@tniessen tniessen tniessen approved these changes

@shigeki shigeki shigeki approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shobhitchittora @vsemozhetbyt @mscdex @addaleax @jasnell @shigeki @tniessen @trivikr @nodejs-github-bot