Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify types of listener parameter #20405

Closed
wants to merge 1 commit into from
Closed

doc: specify types of listener parameter #20405

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

We cannot manage with {any} because message cannot be of Symbol or undefined types.

@vsemozhetbyt
doc: specify types of listener parameter
a476a34 
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2018
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Apr 29, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt
Copy link
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/624/

@vsemozhetbyt vsemozhetbyt mentioned this pull request Apr 29, 2018
Closed
4 tasks
vsemozhetbyt added a commit that referenced this pull request May 2, 2018
@vsemozhetbyt
doc: specify types of listener parameter
aaca38a 
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.

PR-URL: #20405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in aaca38a
Thanks for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-process-specify-listener-param-type branch May 2, 2018 02:59
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@vsemozhetbyt @MylesBorins
doc: specify types of listener parameter
54e9331 
We cannot manage with `{any}` because `message` cannot be
of `Symbol` or `undefined` types.

PR-URL: #20405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vsemozhetbyt @lpinca @cjihrig @nodejs-github-bot