doc: remove superfluous URL require statement #20364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 27, 2018
|
I think this can be fast-tracked, please 👍 if you agree. CI lite: https://ci.nodejs.org/job/node-test-commit-lite/786/ (edit: green) |
|
Just noticed I misspelled "superfluous" in the commit message. May I ask: What is the recommended way of fixing this? |
|
@MarkTiedemann You can either try to change the commit message yourself (running |
Since v10.0.0, the `URL` class is available on the global object, so using a `require` statement to access it is no longer necessary.
53b0a37 to
707b5c9
Compare
targos
approved these changes
Apr 27, 2018
|
@addaleax Thank you for the help! I fixed the typo and pushed with |
vsemozhetbyt
approved these changes
Apr 27, 2018
|
Landed in 6c6f313 |
addaleax
pushed a commit
that referenced
this pull request
Apr 27, 2018
Since v10.0.0, the `URL` class is available on the global object, so using a `require` statement to access it is no longer necessary. PR-URL: #20364 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
Since v10.0.0, the `URL` class is available on the global object, so using a `require` statement to access it is no longer necessary. PR-URL: #20364 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v10.0.0, the
URLclass is available on the global object, sousing a
requirestatement to access it is no longer necessary.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes