console: fix console.table() display edge case #20323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the properties are not specified in `console.table()`, then we should make a best effort to determine them rather than put all values into a "Values" column.
devsnek
approved these changes
Apr 26, 2018
|
node-test-commit-linux re-run: https://ci.nodejs.org/job/node-test-commit-linux/18297/ |
trivikr
approved these changes
Apr 26, 2018
benjamingr
approved these changes
Apr 26, 2018
sant123
approved these changes
Apr 26, 2018
|
@sant123 thanks for the review! |
TimothyGu
approved these changes
Apr 26, 2018
BridgeAR
approved these changes
Apr 26, 2018
jasnell
approved these changes
Apr 27, 2018
mithunsasidharan
approved these changes
Apr 27, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 28, 2018
If the properties are not specified in `console.table()`, then we should make a best effort to determine them rather than put all values into a "Values" column. PR-URL: nodejs#20323 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 99d56a4 |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
If the properties are not specified in `console.table()`, then we should make a best effort to determine them rather than put all values into a "Values" column. PR-URL: #20323 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the properties are not specified in
console.table(), then we shouldmake a best effort to determine them rather than put all values into a
"Values" column.
Refs: #20318 (review)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes@devsnek