-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: unify format of iterables #20036
Conversation
Also, make signatures easier for copy-paste testing.
I personally feel |
@TimothyGu I mean mostly these reasons:
However, if somebody does have objections, I will revert these parts. |
Landed in ff4ca64 |
Also, make signatures easier for copy-paste testing. PR-URL: #20036 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Interesting point. On the other hand, it inspires the question of who would want to copy-paste this function in the first place since it's such a low level API.
Fair point, but I'm not convinced that should be the primary reason this gets landed. Procedurally, I am not very happy with how this PR was fast-tracked. Even though I did not explicitly block this pull request, I'd like to note that COLLABORATOR_GUIDE says:
In the future I would prefer to get a chance to reply to any responses to my comments before the PR gets merged rather than after, especially considering the fact that this PR was created and applied in a 20-hour span over the weekends. |
@TimothyGu Sorry. I will wait more time if any non-blocked concerns expressed. |
Also, make signatures easier for copy-paste testing. PR-URL: #20036 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Also, make signatures easier for copy-paste testing. PR-URL: nodejs#20036 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAlso, make signatures easier for copy-paste testing.