Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v9.x] net: handle allowHalfOpen before calling super ctor #19772

Closed
wants to merge 3 commits into from
Closed

[v9.x] net: handle allowHalfOpen before calling super ctor #19772

wants to merge 3 commits into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 3, 2018

If the allowHalfOpen option is not provided, use its default value
before calling the Duplex constructor. This allows the no-half-open
enforcer to be properly added.

Fixes: #19764

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

lpinca added 3 commits April 3, 2018 12:23
@lpinca
Revert "stream: make Duplex inherits from DuplexBase"
588bcf0 
This reverts commit 152c931.
@lpinca
Revert "net: do not inherit the no-half-open enforcer"
fb938e4 
This reverts commit 5b12d3a.
@lpinca
net: handle allowHalfOpen before calling super ctor
36b5e01 
If the `allowHalfOpen` option is not provided, use its default value
before calling the `Duplex` constructor. This allows the no-half-open
enforcer to be properly added.

Fixes: nodejs#19764
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem. v9.x labels Apr 3, 2018
@lpinca
Copy link
Member Author

lpinca commented Apr 3, 2018

I would prefer not to land this as the change in behavior described in #19764 is actually a bug fix. If the only affected module is node-subcomandante I think it's better to fix the issue there.

@lpinca
Copy link
Member Author

lpinca commented Apr 3, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14018/

@lpinca lpinca mentioned this pull request Apr 5, 2018
Merged
@lpinca
Copy link
Member Author

lpinca commented Apr 13, 2018 •
edited
Loading

@nodejs/collaborators @nodejs/lts before I rebase, what do you think? See also #19764.

@lpinca
Copy link
Member Author

lpinca commented May 1, 2018

Should I close this and mark the original issue as won't fix?

@tniessen
Copy link
Member

tniessen commented May 2, 2018

Should I close this and mark the original issue as won't fix?

@lpinca Given that there hasn't been any activity around this for a month, it probably won't do any harm to do so.

@lpinca
Copy link
Member Author

lpinca commented May 2, 2018

Ok, thanks.

@lpinca lpinca closed this May 2, 2018
@lpinca lpinca deleted the gh-19764 branch May 2, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpinca @tniessen @nodejs-github-bot