Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v8.x backport] http, tls: better support for IPv6 addresses #18317

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
abb7aa5
deps: cherry-pick c3458a8 from upstream V8
targos Jan 9, 2018
705a867
deps: update V8 to 6.2.414.46
targos Jan 15, 2018
e6f8320
src: update NODE_MODULE_VERSION to 59
targos Jan 15, 2018
0eb364d
test: fix message test after V8 upgrade
targos Aug 28, 2017
a4c3c0c
src: update ustack offset identifiers
geek Aug 28, 2017
85ccf65
src: fix rename of entry frame in v8abbr.h
geek Aug 29, 2017
94827f5
deps: cherry-pick 9b21865822243 from V8 upstream
addaleax Sep 8, 2017
59108d3
deps: v8: fix potential segfault in profiler
ofrobots Sep 20, 2017
4ad5cd4
deps: backport 0f1dfae from V8 upstream
tebbi Oct 10, 2017
91dc965
deps: cherry-pick 37a3a15c3 from V8 upstream
fhinkel Oct 18, 2017
c38efe8
deps: cherry-pick 2c75616 from upstream V8
targos Oct 25, 2017
3e93d44
deps: cherry-pick 676c413 from upstream V8
targos Oct 25, 2017
0dcdc63
deps: cherry-pick e0d64dc from upstream V8
targos Oct 25, 2017
b150338
deps: V8: backport b1cd96e from upstream
ofrobots Oct 18, 2017
2153adb
deps: cherry-pick b8331cc030 from upstream V8
danbev Oct 30, 2017
7fa99f0
deps: cherry-pick cc55747 from V8 upstream
fhinkel Nov 8, 2017
74bcf98
deps: cherry-pick 1420e44db0 from upstream V8
TimothyGu Nov 27, 2017
5854746
deps: backport 3c8195d from V8 upstream
MylesBorins Nov 8, 2017
8b757a8
deps: V8: backport 14ac02c from upstream
ofrobots Dec 6, 2017
2a95ba0
deps: V8: cherry-pick ac0fe8ec from upstream
ofrobots Dec 15, 2017
2785cc5
deps: cherry-pick c3458a8 from upstream V8
targos Jan 11, 2018
9930b4b
deps: revert ABI breaking changes in V8 6.2
addaleax Oct 13, 2017
30f0b0a
deps: revert ABI breaking changes in V8 6.1
addaleax Sep 14, 2017
4899eea
win, build: fix without-intl option
bzoz Dec 11, 2017
9d3e4c0
test: fix flaky test-benchmark-misc
Trott Dec 14, 2017
57e4cfd
tools: simplify lowercase-name-for-primitive rule
cjihrig Dec 13, 2017
7b211bb
doc: add C++ style comments to the style guide
Dec 11, 2017
825e810
http: remove adapter frame from onParserExecute
bnoordhuis Dec 15, 2017
b6c65af
test: change callback function to arrow function
skanamaru Dec 15, 2017
73d3f8c
test: change callback function to arrow function
you12724 Dec 15, 2017
e63ad6b
test: change callback function to arrow function
routerman Dec 15, 2017
53b2a98
test: check socketOnDrain where needPause is false
Leko Dec 13, 2017
6215004
doc: change "Node.js style cb" to "error-first cb"
ramsgoli Dec 12, 2017
a1b332d
test: coverage for emitExperimentalWarning
mithunsasidharan Dec 13, 2017
cd88918
doc: add countdown module to writing tests guide
Bamieh Dec 12, 2017
005e367
test: update test-http-content-length to use countdown
Bamieh Dec 12, 2017
ef61f12
test: Use countdown in test file
sreepurnajasti Dec 13, 2017
6cd3f78
test: add test for postmortem metadata validation
cjihrig Dec 14, 2017
a64f00d
doc: improve documentation.md
Fishrock123 Dec 15, 2017
8f21c6a
doc: fix fs.existsSync description
Fishrock123 Dec 15, 2017
9ee35b5
doc: adjust TTY wording & add inter-doc links
Fishrock123 Dec 15, 2017
00130dc
doc: not all example code can be run without 1:1
Fishrock123 Dec 15, 2017
ffb063d
doc: improve release guide
evanlucas Dec 14, 2017
81900fc
doc: edit CONTRIBUTING.md preamble
Trott Dec 15, 2017
fa8827c
doc: fix typo in child_process.md
Trott Dec 18, 2017
e04b054
doc: fix typo in README.md
starkwang Dec 18, 2017
715d113
doc: remove duplicate the from onboarding.md
sreepurnajasti Dec 18, 2017
a6ab0a1
src: remove nonexistent method from header file
addaleax Dec 19, 2017
b99ebde
test: change callback function to arrow function
rt33 Dec 18, 2017
7fa140f
crypto: remove unused header in clienthello.h
danbev Dec 19, 2017
a84d145
tools: add number-isnan rule
maclover7 Dec 11, 2017
2bf0796
test: fix typo in test-inspector-cluster-port-clash.js
Trott Dec 20, 2017
581fe1f
net: remove ADDRCONFIG DNS hint on Windows
bzoz Dec 13, 2017
f275ff1
http, tls: better support for IPv6 addresses
mattiasholmlund Aug 10, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
16 changes: 7 additions & 9 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
# Contributing to Node.js

Contributions to Node.js may come in many forms. Some contribute code changes,
others contribute docs, others help answer questions from users, help keep the
infrastructure running, or seek out ways of advocating for Node.js users of all
types.
Contributions to Node.js include code, documentation, answering user questions,
running the project's infrastructure, and advocating for all types of Node.js
users.

The Node.js project welcomes all contributions from anyone willing to work in
good faith both with other contributors and with the community. No contribution
is too small and all contributions are valued.
good faith with other contributors and the community. No contribution is too
small and all contributions are valued.

This guide details the basic steps for getting started contributing to the
Node.js project's core `nodejs/node` GitHub Repository and describes what to
expect throughout each step of the process.
This guide explains the process for contributing to the Node.js project's core
`nodejs/node` GitHub Repository and describes what to expect at each step.

* [Code of Conduct](#code-of-conduct)
* [Bad Actors](#bad-actors)
Expand Down
21 changes: 21 additions & 0 deletions CPP_STYLE_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

* [Formatting](#formatting)
* [Left-leaning (C++ style) asterisks for pointer declarations](#left-leaning-c-style-asterisks-for-pointer-declarations)
* [C++ style comments](#c-style-comments)
* [2 spaces of indentation for blocks or bodies of conditionals](#2-spaces-of-indentation-for-blocks-or-bodies-of-conditionals)
* [4 spaces of indentation for statement continuations](#4-spaces-of-indentation-for-statement-continuations)
* [Align function arguments vertically](#align-function-arguments-vertically)
Expand Down Expand Up @@ -33,6 +34,26 @@ these rules:

`char* buffer;` instead of `char *buffer;`

## C++ style comments

Use C++ style comments (`//`) for both single-line and multi-line comments.
Comments should also start with uppercase and finish with a dot.

Examples:

```c++
// A single-line comment.

// Multi-line comments
// should also use C++
// style comments.
```

The codebase may contain old C style comments (`/* */`) from before this was the
preferred style. Feel free to update old comments to the preferred style when
working on code in the immediate vicinity or when changing/improving those
comments.

## 2 spaces of indentation for blocks or bodies of conditionals

```c++
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ or availability of the Node.js application or its system for which the attacker
does not already have the capability.

To illustrate the point, here are some examples of past issues and what the
Security Reponse Team thinks of them. When in doubt, however, please do send
Security Response Team thinks of them. When in doubt, however, please do send
us a report nonetheless.


Expand Down
9 changes: 9 additions & 0 deletions deps/v8/.editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true

[*]
charset = utf-8
indent_style = space
indent_size = 2
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
1 change: 1 addition & 0 deletions deps/v8/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
.project
.pydevproject
.settings
.vscode
/_*
/build
/buildtools
Expand Down
7 changes: 6 additions & 1 deletion deps/v8/AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ Amazon, Inc <*@amazon.com>
ST Microelectronics <*@st.com>
Yandex LLC <*@yandex-team.ru>
StrongLoop, Inc. <*@strongloop.com>
Facebook, Inc. <*@fb.com>
Facebook, Inc. <*@oculus.com>

Aaron Bieber <deftly@gmail.com>
Abdulla Kamar <abdulla.kamar@gmail.com>
Expand Down Expand Up @@ -88,6 +90,7 @@ Luis Reis <luis.m.reis@gmail.com>
Luke Zarko <lukezarko@gmail.com>
Maciej Małecki <me@mmalecki.com>
Marcin Cieślak <saper@marcincieslak.com>
Mateusz Czeladka <mateusz.szczap@gmail.com>
Mathias Bynens <mathias@qiwi.be>
Matt Hanselman <mjhanselman@gmail.com>
Matthew Sporleder <msporleder@gmail.com>
Expand All @@ -100,12 +103,14 @@ Mike Pennisi <mike@mikepennisi.com>
Milton Chiang <milton.chiang@mediatek.com>
Myeong-bo Shim <m0609.shim@samsung.com>
Nicolas Antonius Ernst Leopold Maria Kaiser <nikai@nikai.net>
Niklas Hambüchen <mail@nh2.me>
Noj Vek <nojvek@gmail.com>
Oleksandr Chekhovskyi <oleksandr.chekhovskyi@gmail.com>
Paolo Giarrusso <p.giarrusso@gmail.com>
Patrick Gansterer <paroga@paroga.com>
Peter Rybin <peter.rybin@gmail.com>
Peter Varga <pvarga@inf.u-szeged.hu>
Peter Wong <peter.wm.wong@gmail.com>
Paul Lind <plind44@gmail.com>
Qiuyi Zhang <qiuyi.zqy@alibaba-inc.com>
Rafal Krypa <rafal@krypa.net>
Expand All @@ -130,4 +135,4 @@ Wiktor Garbacz <wiktor.garbacz@gmail.com>
Yu Yin <xwafish@gmail.com>
Zac Hansen <xaxxon@gmail.com>
Zhongping Wang <kewpie.w.zp@gmail.com>
柳荣一 <admin@web-tinker.com>
柳荣一 <admin@web-tinker.com>
Loading