Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor test-repl-definecommand #17795

Closed
wants to merge 2 commits into from
Closed

test: refactor test-repl-definecommand #17795

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec342e
test: refactor test-repl-definecommand
Trott Dec 20, 2017
309ab33
Update test-repl-definecommand.js
Trott Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions test/parallel/test-repl-definecommand.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,28 @@ r.defineCommand('say1', {
help: 'help for say1',
action: function(thing) {
output = '';
this.write(`hello ${thing}`);
this.output.write(`hello ${thing}\n`);
this.displayPrompt();
}
});

r.defineCommand('say2', function() {
output = '';
this.write('hello from say2');
this.output.write('hello from say2\n');
this.displayPrompt();
});

inputStream.write('.help\n');
assert(/\n\.say1 help for say1\n/.test(output),
'help for say1 not present');
assert.ok(/\n\.say1 help for say1\n/.test(output),
'help for say1 not present');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a independent change. I do not really see why this should be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to standardize on assert.ok() for tests, but I see I also missed one on another line. Anyway, yes, it's unnecessary, so I'll undo it.

assert(/\n\.say2\n/.test(output), 'help for say2 not present');
inputStream.write('.say1 node developer\n');
assert(/> hello node developer/.test(output), 'say1 outputted incorrectly');
assert.ok(output.startsWith('hello node developer\n'),
`say1 output starts incorrectly: "${output}"`);
assert.ok(output.includes('> '),
`say1 output does not include prompt: "${output}"`);
inputStream.write('.say2 node developer\n');
assert(/> hello from say2/.test(output), 'say2 outputted incorrectly');
assert.ok(output.startsWith('hello from say2\n'),
`say2 output starts incorrectly: "${output}"`);
assert.ok(output.includes('> '),
`say2 output does not include prompt: "${output}"`);