Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] doc: more accurate zlib windowBits information #16623

Closed
wants to merge 1 commit into from
Closed

[v8.x] doc: more accurate zlib windowBits information #16623

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fixes: #14847
Original-PR-URL: #16511

@addaleax
doc: more accurate zlib windowBits information
605e0fc 
Fixes: nodejs#14847
Original-PR-URL: nodejs#16511
Original-Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Original-Reviewed-By: James M Snell <jasnell@gmail.com>
Original-Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Original-Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Original-Reviewed-By: Refael Ackermann <refack@gmail.com>
@addaleax
Copy link
Member Author

@gibfahn

@gibfahn
Copy link
Member

gibfahn commented Oct 30, 2017

Wow, thanks for being so quick on this.

Quick question, you changed the fields in the commit message to Original-PR-URL: and Original-Reviewed-By:. I thought we were still doing PR-URL: and then Backport-PR-URL:.

I'm happy to change them back (already have on my local branch) if that's the correct thing to do, but I just want to make sure I'm not missing a trick 😁.

CI: https://ci.nodejs.org/job/node-test-commit/13612/

@addaleax
Copy link
Member Author

@gibfahn I might be mixing things up, I know @MylesBorins corrected me on this once before, but generally do whatever you think is the right one :)

gibfahn pushed a commit to gibfahn/node that referenced this pull request Oct 30, 2017
@addaleax @gibfahn
doc: more accurate zlib windowBits information
419dc62 
Fixes: nodejs#14847
PR-URL: nodejs#16511
Backport-PR-URL: nodejs#16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@gibfahn gibfahn force-pushed the v8.x-staging branch 4 times, most recently from b183192 to fc8acc8 Compare October 30, 2017 21:42
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@addaleax @gibfahn
doc: more accurate zlib windowBits information
91c4718 
Fixes: #14847
PR-URL: #16511
Backport-PR-URL: #16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Oct 30, 2017

Thanks @addaleax ! Landed in 91c4718

DW about CI, that was due to unrelated issues.

@gibfahn gibfahn closed this Oct 30, 2017
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@addaleax @gibfahn
doc: more accurate zlib windowBits information
d222c65 
Fixes: #14847
PR-URL: #16511
Backport-PR-URL: #16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@addaleax @gibfahn
doc: more accurate zlib windowBits information
a6b3cd8 
Fixes: #14847
PR-URL: #16511
Backport-PR-URL: #16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@addaleax addaleax deleted the 16511-8.x branch November 16, 2017 21:35
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@addaleax @MylesBorins
doc: more accurate zlib windowBits information
f671690 
Fixes: #14847
PR-URL: #16511
Backport-PR-URL: #16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@addaleax @MylesBorins
doc: more accurate zlib windowBits information
0cd5845 
Fixes: #14847
PR-URL: #16511
Backport-PR-URL: #16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@addaleax @MylesBorins
doc: more accurate zlib windowBits information
44c0385 
Fixes: #14847
PR-URL: #16511
Backport-PR-URL: #16623
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @gibfahn @apapirovski @lpinca @nodejs-github-bot