Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http2 API docs typos #15778

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions doc/api/http2.md
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ const {

const req = clientSession.request({ [HTTP2_HEADER_PATH]: '/' });
req.on('response', (headers) => {
console.log(HTTP2_HEADER_STATUS);
console.log(headers[HTTP2_HEADER_STATUS]);
req.on('data', (chunk) => { /** .. **/ });
req.on('end', () => { /** .. **/ });
});
Expand Down Expand Up @@ -828,8 +828,8 @@ added: v8.4.0
* Value: {Object}
* `localWindowSize` {number}
* `state` {number}
* `streamLocalClose` {number}
* `streamRemoteClose` {number}
* `localClose` {number}
* `remoteClose` {number}
* `sumDependencyWeight` {number}
* `weight` {number}

Expand Down Expand Up @@ -1368,7 +1368,7 @@ added: v8.4.0
The `'unknownProtocol'` event is emitted when a connecting client fails to
negotiate an allowed protocol (i.e. HTTP/2 or HTTP/1.1). The event handler
receives the socket for handling. If no listener is registered for this event,
the connection is terminated. See the
the connection is terminated. See the [Compatibility API][].

#### Event: 'stream'
<!-- YAML
Expand Down