Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: deprecate obj.inspect for custom inspection #15631

Closed
wants to merge 2 commits into from
Closed

util: deprecate obj.inspect for custom inspection #15631

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b5864e
util: deprecate obj.inspect for custom inspection
Trott Sep 26, 2017
1a791e8
squash: suggestion from addaleax
Trott Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,8 @@ Type: Documentation-only

Using a property named `inspect` on an object to specify a custom inspection
function for [`util.inspect()`][] is deprecated. Use [`util.inspect.custom`][]
instead.
instead. (For backwards compatibility with Node.js prior to version 6.4.0, both
may be specified.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead (For backwards compatibility with Node.js prior to version 6.4.0, both may be specified). ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since it's a whole sentence (not just a clause) inside the parentheses the period should be inside.
image
http://www.thepunctuationguide.com/parentheses.html

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the parentheses are unnecessary anyway?


[`Buffer.allocUnsafeSlow(size)`]: buffer.html#buffer_class_method_buffer_allocunsafeslow_size
[`Buffer.from(array)`]: buffer.html#buffer_class_method_buffer_from_array
Expand Down