Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: do not compact stability text to one line #14929

Closed
wants to merge 1 commit into from

Conversation

maclover7
Copy link
Contributor

@maclover7 maclover7 commented Aug 18, 2017

Previously, stability descriptions were strung together as one long
horizontal row at https://nodejs.org/api/documentation.html. Now, the text now will
auto-expand vertically, so you can see all of the text at once.

Note that the CSS options for how to handle this are somewhat
constrained since the paragraphs are being rendered through pre
elements, and the third party syntax highlighting library does apply its
own styling.

Before: https://cl.ly/2w2O0z1T2o0Y
After: https://cl.ly/3z1i1t2D2r41

This does not affect the stability boxes for features, as those were
not previously affected by this bug, and are only a few words long.

Checklist
Affected core subsystem(s)

doc

Previously, stability descriptions were strung together as one long
horizontal row at https://nodejs.org/api/documentation.html. Now, the text now will
auto-expand vertically, so you can see all of the text at once.

Note that the CSS options for how to handle this are somewhat
constrained since the paragraphs are being rendered through `pre`
elements, and the third party syntax highlighting library does apply its
own styling.

Before: https://cl.ly/2w2O0z1T2o0Y
After: https://cl.ly/3z1i1t2D2r41

This does not affect the stability boxes for features, as thouse were
not previously affected by this bug, and are only a few words long.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 18, 2017
@tniessen
Copy link
Member

I believe this was fixed in #14809, @saadq?

@maclover7
Copy link
Contributor Author

👍 apologies, can confirm solved via #14809. Was checking nodejs.org/api, not nightly docs.

@maclover7 maclover7 closed this Aug 18, 2017
@maclover7 maclover7 deleted the jm-expand-stability branch August 18, 2017 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants