Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.x backport] Eslint 4.1.0 #14830

Closed
wants to merge 59 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
3edd272
test: add common.noop, default for common.mustCall()
jasnell Mar 24, 2017
2d96b01
tools: add rule prefering common.mustNotCall()
jasnell Mar 24, 2017
ce86b8e
test: add mustCallAtLeast
refack May 9, 2017
189dc42
test: harden test-dgram-bind-shared-ports
refack May 18, 2017
a28f7a2
dns: fix `resolve` failed starts without network
XadillaX Aug 10, 2017
cb3b866
src: supply missing comments for CLI options
sam-github Apr 5, 2017
1576c09
src: use option parser for expose_internals
sam-github Apr 5, 2017
ee98df8
test: mark test-fs-read-buffer-to-string-fail as flaky
Jeyanthinath Jul 26, 2017
3f2b8a9
test: increase coverage for path.parse
tniessen Jul 24, 2017
ba411f1
path: fix win32 volume-relative paths
TimothyGu Jul 24, 2017
d75363b
path: remove unnecessary string copies
tniessen Jul 23, 2017
cbd2c77
tools: add missing #include "unicode/putil.h"
srl295 Mar 27, 2017
0f36025
timers: do not use user object call/apply
Trott May 11, 2017
c7622e1
deps: cherry-pick f5fad6d from upstream v8
danbev May 2, 2017
2914926
src: only call FatalException if not verbose
danbev May 3, 2017
9dde328
build: reduce one level of spawning in node_gyp
refack Apr 25, 2017
4072073
test: check number of message events
Trott May 20, 2017
548aba4
test: confirm callback is invoked in fs test
Trott May 20, 2017
4442a1f
test: check noop function invocations
Trott May 21, 2017
85a8d6e
test: simplify assert usage in test-stream2-basic
Trott May 21, 2017
10ad128
test: move stream2 test from pummel to parallel
Trott May 21, 2017
8fd7fcc
build: support dtrace on ARM
bradleythughes Mar 27, 2017
6ca963a
test: replace `indexOf` with `includes`
thelostone-mc May 25, 2017
b997b8f
test: use mustNotCall() in test-stream2-objects
Trott May 26, 2017
7919eee
test: use mustCall() in test-readline-interface
Trott May 27, 2017
089bd3b
test: refactor test-net-server-bind
Trott May 29, 2017
30201e5
test: add documentation for common.mustNotCall()
Trott Jun 1, 2017
7c2befc
test: refactor test-dgram-oob-buffer
Trott Jun 3, 2017
c15393c
test: check callback not invoked on lookup error
Trott Jun 4, 2017
1a95a51
test: refactor domain tests
Trott Jun 5, 2017
8033cf3
test: refactor test-fs-read-*
Trott Jun 6, 2017
bfea6b2
src: merge `fn_name` in NODE_SET_PROTOTYPE_METHOD
XadillaX Jun 8, 2017
245f6b0
test: use mustNotCall in test-http-eof-on-connect
Trott Jun 9, 2017
6f44563
test: add mustCall() to child-process test
Trott Jun 11, 2017
2f8aa88
test: use mustNotCall() in test-fs-watch
Trott Jun 10, 2017
ac99a79
v8: fix RegExp nits in v8_prof_polyfill.js
vsemozhetbyt Jun 15, 2017
10e9f45
test: make test-http(s)-set-timeout-server alike
jklepatch Jun 12, 2017
7aee51f
test: refactor test-http-set-timeout-server
Trott Jun 19, 2017
2ef11d5
test: remove needless RegExp flags
vsemozhetbyt Jun 15, 2017
29141c0
test: use string instead of RegExp in split()
vsemozhetbyt Jun 16, 2017
366d1a8
doc: add missing zlib link to stream API docs
Rob--W Jun 21, 2017
b5d763f
test: remove unnecessary Buffer import
swinston1000 Jun 21, 2017
dda959d
test: remove require('buffer') on 6 fs test files
sallen450 Jun 21, 2017
611ae1e
test: remove require('buffer') from 4 buffer tests
OriLev Jun 21, 2017
bfd296b
test: remove `require('buffer')` from 4 test files
leizongmin Jun 21, 2017
036a97c
test: remove unnecessary require('buffer').Buffer
lenakaplan Jun 21, 2017
47dd8f0
test: remove `require('buffer')` from 4 test files
XadillaX Jun 21, 2017
b801c75
build: clean up config_fips.gypi
danbev Jun 21, 2017
cb8d837
test: make http(s)-set-timeout-server more similar
jklepatch Jun 20, 2017
b9837ff
test: refactor test-tls-env-extra-ca
Trott Jun 23, 2017
e5f8141
test: refactor test-tls-invoked-queued
Trott Jun 23, 2017
3a45bde
test: skip fips tests using OpenSSL config file
danbev Jun 18, 2017
da8851c
doc: fixed formatting issue in cli docs
Jun 20, 2017
8fcae92
test: remove unneeded HandleScope usage
ezequielgarcia Jun 19, 2017
9575c97
doc: fix mistake in path.relative
tniessen Jun 25, 2017
1ae897d
doc: add gireeshpunathil to collaborators
gireeshpunathil Jun 28, 2017
92c46ff
doc: add @nodejs/documentation to CC table
vsemozhetbyt Jun 27, 2017
7f77286
tools: update to ESLint 4.1.0
Trott Jun 24, 2017
b7a0867
tools: add script to update ESLint
Trott Jun 24, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: merge fn_name in NODE_SET_PROTOTYPE_METHOD
Merge two duplicate `fn_name` into one in NODE_SET_PROTOTYPE_METHOD,
it may improve a bit performance.

PR-URL: #13547
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
XadillaX authored and MylesBorins committed Aug 14, 2017
commit bfea6b26f0c6232e58722c25f7365ad47e241ef9
2 changes: 1 addition & 1 deletion src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ inline void NODE_SET_PROTOTYPE_METHOD(v8::Local<v8::FunctionTemplate> recv,
v8::FunctionTemplate::New(isolate, callback, v8::Local<v8::Value>(), s);
v8::Local<v8::String> fn_name = v8::String::NewFromUtf8(isolate, name);
t->SetClassName(fn_name);
recv->PrototypeTemplate()->Set(v8::String::NewFromUtf8(isolate, name), t);
recv->PrototypeTemplate()->Set(fn_name, t);
}
#define NODE_SET_PROTOTYPE_METHOD node::NODE_SET_PROTOTYPE_METHOD

Expand Down