Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: do not consider ... as a REPL command #14467

Closed
wants to merge 5 commits into from
Closed

repl: do not consider ... as a REPL command #14467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5b6ec8
repl:Do not consider `...` as a REPL command
shivanth Jul 23, 2017
e2a61f6
use !== instead of !=
shivanth Jul 25, 2017
067ed99
Add test for REPL
shivanth Jul 26, 2017
cfce5a2
Fix the test, add the .break command after the test
shivanth Jul 26, 2017
08327ff
Make a more concrete test case
shivanth Jul 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ function REPLServer(prompt,
// Check to see if a REPL keyword was used. If it returns true,
// display next prompt and return.
if (trimmedCmd) {
if (trimmedCmd.charAt(0) === '.' && isNaN(parseFloat(trimmedCmd))) {
if (trimmedCmd.charAt(0) === '.' && trimmedCmd.charAt(1) !== '.' && isNaN(parseFloat(trimmedCmd))) {
const matches = trimmedCmd.match(/^\.([^\s]+)\s*(.*)$/);
const keyword = matches && matches[1];
const rest = matches && matches[2];
Expand Down
9 changes: 8 additions & 1 deletion test/parallel/test-repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,14 @@ function error_test() {
expect: `${prompt_multiline}'foo \\n'\n${prompt_unix}` },
// Whitespace is not evaluated.
{ client: client_unix, send: ' \t \n',
expect: prompt_unix }
expect: prompt_unix },
//Do not parse `...[]` as a REPL keyword
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the linter might fail due to no space between the comment start?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes as we do not use the spaced-comment rule. I fixed it anyways.

{ client: client_unix, send: '...[]\n',
expect: `${prompt_multiline}` },
//bring back the repl to prompt
{ client: client_unix, send: '.break',
expect: `${prompt_unix}` }

]);
}

Expand Down