Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-fs-read-stream #13643

Closed
wants to merge 1 commit into from
Closed

test: refactor test-fs-read-stream #13643

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 13, 2017

  • alphabetize modules
  • replace callback invocation counts with common.mustCall()
  • add block-scoping
  • remove commented-out code that uses an identifier not in the test
  • move exit handlers to relevant blocks to keep tests cohesive
  • common.noop -> common.mustNotCall()
  • check results from data event
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test fs

@Trott Trott added fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests. labels Jun 13, 2017
refack
refack approved these changes Jun 13, 2017
View reviewed changes
Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just when I fell in 💘 with ?w=1 github fails again since you can't comment in w=1 mode.

test/parallel/test-fs-read-stream.js Outdated
}

{
// https://github.com/joyent/node/issues/2320
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this live forever? Change to // Ref: https://github.com/nodejs/node-v0.x-archive/issues/2320?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

@lpinca
Copy link
Member

lpinca commented Jun 14, 2017

There are some file.on('end', ...) which could use a common.mustCall() wrapped listener.

@Trott Trott force-pushed the refactor-test-fs-read-stream branch from e72df72 to 769d92a Compare June 14, 2017 21:44
@Trott
test: refactor test-fs-read-stream
6741446 
* alphabetize modules
* replace callback invocation counts with common.mustCall()
* add block-scoping
* remove commented-out code that uses an identifier not in the test
* move exit handlers to relevant blocks to keep tests cohesive
* common.noop -> common.mustNotCall()
* check results from `data` event
@Trott
Copy link
Member Author

Trott commented Jun 14, 2017

@lpinca Good catch. Done!

@Trott Trott force-pushed the refactor-test-fs-read-stream branch from 769d92a to 6741446 Compare June 14, 2017 21:46
@Trott
Copy link
Member Author

Trott commented Jun 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8662/

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

Lone CI failure is a Jenkins issue unrelated to this change.

@Trott
Copy link
Member Author

Trott commented Jun 16, 2017

Landed in e74907b

@Trott Trott closed this Jun 16, 2017
Trott added a commit that referenced this pull request Jun 16, 2017
@Trott
test: refactor test-fs-read-stream
e74907b 
* alphabetize modules
* replace callback invocation counts with common.mustCall()
* add block-scoping
* remove commented-out code that uses an identifier not in the test
* move exit handlers to relevant blocks to keep tests cohesive
* common.noop -> common.mustNotCall()
* check results from `data` event

PR-URL: #13643
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit that referenced this pull request Jun 17, 2017
@Trott @addaleax
test: refactor test-fs-read-stream
e8ea2e4 
* alphabetize modules
* replace callback invocation counts with common.mustCall()
* add block-scoping
* remove commented-out code that uses an identifier not in the test
* move exit handlers to relevant blocks to keep tests cohesive
* common.noop -> common.mustNotCall()
* check results from `data` event

PR-URL: #13643
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax mentioned this pull request Jun 17, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@Trott @addaleax
test: refactor test-fs-read-stream
ba20627 
* alphabetize modules
* replace callback invocation counts with common.mustCall()
* add block-scoping
* remove commented-out code that uses an identifier not in the test
* move exit handlers to relevant blocks to keep tests cohesive
* common.noop -> common.mustNotCall()
* check results from `data` event

PR-URL: #13643
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
@Trott Trott deleted the refactor-test-fs-read-stream branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @lpinca @refack @jasnell @cjihrig @MylesBorins