-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Scrollbar width #6443
Comments
Even on 1366x768 they are hard to hit, both the TOC and the content scrollbars. |
It looks like that to me. It's fine, but could be a bit wider though.
Note that device pixels and (css) reference pixels are not the same. Reference pixel is defined though visual angle. So, this should not depend on the devices resolution, but instead the actual question is — is 10 reference pixels scrollbar too small? |
@ChALkeR Yes but it is PPI dependend. My Monitor got 190PPI and the scrollbar is really tricky to click. Often I even cant see the grey bar on the white background :) |
@mathiask88 This looks like your machine is misconfigured, then. The visual angle of one css pixel isn't PPI dependent (except for rounding error). It's the visual angle and the PPI that define the device pixel ratio that should be set on your system for everything to be rendered correctly. |
@ChALkeR Thanks, I learned something new :) Nevertheless for me personally it is definitely too small :/ |
I'll whip up a quick PR with a media query or two. Would you consider 20px to be reasonable for widths 2048 and higher? I don't have a big enough monitor on me at the moment. |
@mathiask88 CSS pixels were the same as device pixels when the latest Firefox version was 3.6 (don't confuse with 36). Reference: https://www.w3.org/TR/css3-values/#absolute-lengths
For example, for PPI = 380 the scrollbars shouldn't be smaller than for PPI = 96, they would be more accurately drawn, because the device pixel ratio would be equal to 4 (for a device at the distance of an arm's length, e.g. a monitor). |
@ChALkeR Ok got it. But I like the default 96dpi setting in windows on my 190PPI device so as a result i got a device pixel ratio of 1. And because I am also about 1 arm lenght away from my monitor the bars are only half the size of e.g your device. If i compare your screenshot with mine i need a zoom of ~200% for the same size (device pixel ratio is then 2) So I would like to stay at 96 dpi scaling in windows and be able to click that scroll bars :) It would also be okay if the bar in the content frame would be non custom because the size of the default browser bars are okay. |
Adds media queries to doc css to make TOC and content scrollbars wider in larger screens. Fixes: nodejs#6443 PR-URL: nodejs#6445
Returns the scrollbar to native style. Fixes: nodejs#6443
Returns the doc custom scrollbar to native style. Fixes: nodejs#6443 PR-URL: nodejs#6479 Reviewed-By: Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Would it be possible to set the scrollbar width to a reasonably value like
20px
? I'm on a 3440x1440px device and it is so so hard to hit that tiny little bar :)The text was updated successfully, but these errors were encountered: