Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: support sqlite3_create_function #54349

Closed
std-microblock opened this issue Aug 13, 2024 · 0 comments · Fixed by #55985
Closed

sqlite: support sqlite3_create_function #54349

std-microblock opened this issue Aug 13, 2024 · 0 comments · Fixed by #55985
Labels
feature request Issues that request new features to be added to Node.js. sqlite Issues and PRs related to the SQLite subsystem.

Comments

@std-microblock
Copy link

What is the problem this feature will solve?

With sqlite3_create_function(), it's easy to implement customized queries such as regex or nlp search. Also, this enhances alignment with existing sqlite3 libraries in Node.JS world such as sql.js or bettersqlite.

What is the feature you are proposing to solve the problem?

Expose an API like this

What alternatives have you considered?

No response
@std-microblock std-microblock added the feature request Issues that request new features to be added to Node.js. label Aug 13, 2024
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Aug 13, 2024
@avivkeller avivkeller added the sqlite Issues and PRs related to the SQLite subsystem. label Aug 13, 2024
@avivkeller avivkeller moved this from Awaiting Triage to Triaged in Node.js feature requests Aug 13, 2024
cjihrig added a commit to cjihrig/node that referenced this issue Nov 24, 2024
@cjihrig
sqlite: add support for custom functions
9909463 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: nodejs#54349
@cjihrig cjihrig mentioned this issue Nov 24, 2024
Merged
cjihrig added a commit to cjihrig/node that referenced this issue Dec 11, 2024
@cjihrig
sqlite: add support for custom functions
e0435f0 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: nodejs#54349
targos pushed a commit that referenced this issue Dec 13, 2024
@cjihrig @targos
sqlite: add support for custom functions
9d50d9c 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: #54349
PR-URL: #55985
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Dec 18, 2024
@cjihrig @aduh95
sqlite: add support for custom functions
4745798 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: #54349
PR-URL: #55985
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this issue Dec 20, 2024
@cjihrig @ruyadorno
sqlite: add support for custom functions
04d0649 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: #54349
PR-URL: #55985
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this issue Dec 21, 2024
@cjihrig @ruyadorno
sqlite: add support for custom functions
86e4b1c 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: #54349
PR-URL: #55985
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this issue Jan 5, 2025
@cjihrig @ruyadorno
sqlite: add support for custom functions
2268c1e 
This commit adds support to node:sqlite for defining custom
functions that can be invoked from SQL.

Fixes: #54349
PR-URL: #55985
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. sqlite Issues and PRs related to the SQLite subsystem.
Projects
Node.js feature requests
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sqlite: add support for custom functions cjihrig/node
2 participants
@avivkeller @std-microblock