Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Lint broken in CI #5299

Closed
mhdawson opened this issue Feb 18, 2016 · 4 comments
Closed

test: Lint broken in CI #5299

mhdawson opened this issue Feb 18, 2016 · 4 comments
Labels
test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

Lint seems to be broken in the CI

https://ci.nodejs.org/job/node-test-linter/1427/console

Quite possibly due to db91281

@mscdex
@orangemocha
Copy link
Contributor

cc @nodejs/testing

@mhdawson
Copy link
Member Author

Backing out db91281 with

  git checkout fcae05e4b5ee7c0817ca0c9f0bc3df012c1664c7 lib/url.js

seems to resolve in my local run

@Trott
Copy link
Member

Trott commented Feb 18, 2016

It looks like #4892 was landed three weeks after its last CI run happened. In the intervening time, new lint rules were added.

@mscdex
Copy link
Contributor

mscdex commented Feb 18, 2016

#5300

@mhdawson mhdawson added the test Issues and PRs related to the tests. label Feb 18, 2016
@Trott Trott closed this as completed in 7d1d3a6 Feb 18, 2016
rvagg pushed a commit that referenced this issue Feb 21, 2016
@mscdex @rvagg
url: fix lint and deopt issues
4727470 
The deopt issues arose from the use of const in specific situations
that v8 does not fully support yet.

Fixes: #5299
PR-URL: #5300
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @Trott @orangemocha @mhdawson