Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: typo in ngtcp2 maintenance readme #43766

Closed
mscdex opened this issue Jul 10, 2022 · 0 comments
Closed

deps: typo in ngtcp2 maintenance readme #43766

mscdex opened this issue Jul 10, 2022 · 0 comments
Labels
good first issue Issues that are suitable for first-time contributors.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jul 10, 2022 •
edited
Loading

https://github.com/nodejs/node/blob/main/deps/ngtcp2/README.md

we only want the contents o the lib.

should be:

we only want the contents of the lib.
@mscdex mscdex added the good first issue Issues that are suitable for first-time contributors. label Jul 10, 2022
@dancastillo dancastillo mentioned this issue Jul 10, 2022
Merged
Arkrez added a commit to Arkrez/node that referenced this issue Jul 12, 2022
@Arkrez
Fixing typo (issue nodejs#43766)
b643f77 
Line 14 => "directories; from `nghttp3` we only want the contents o the `lib`." to "directories; from `nghttp3` we only want the contents of the `lib`."
@aduh95 aduh95 closed this as completed in f0d0c0c Jul 12, 2022
danielleadams pushed a commit that referenced this issue Jul 26, 2022
@dancastillo @danielleadams
doc: fix typo in ngtcp2 readme
50b3750 
PR-URL: #43767
Fixes: #43766
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
targos pushed a commit that referenced this issue Jul 31, 2022
@dancastillo @targos
doc: fix typo in ngtcp2 readme
f7b8340 
PR-URL: #43767
Fixes: #43766
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
guangwong pushed a commit to noslate-project/node that referenced this issue Oct 10, 2022
@dancastillo @guangwong
doc: fix typo in ngtcp2 readme
4ea26df 
PR-URL: nodejs/node#43767
Fixes: nodejs/node#43766
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mscdex