Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message for invalid directory import #33219

Closed
guybedford opened this issue May 3, 2020 · 0 comments
Closed

Better error message for invalid directory import #33219

guybedford opened this issue May 3, 2020 · 0 comments
Labels
esm Issues and PRs related to the ECMAScript Modules implementation.

Comments

@guybedford
Copy link
Contributor

The following test case was brought up by @addaleax

esm.mjs:

import mod from './';

console.log(mod);

where node esm.mjs fails with

TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension "" for /tmp/test/
    at Loader.defaultGetFormat [as _getFormat] (internal/modules/esm/get_format.js:65:15)

We should ensure the error message here provides the correct steps to resolve the issue.
@guybedford guybedford added the esm Issues and PRs related to the ECMAScript Modules implementation. label May 3, 2020
@aduh95 aduh95 mentioned this issue May 3, 2020
Closed
4 tasks
aduh95 added a commit to aduh95/node that referenced this issue May 4, 2020
@aduh95
module: add specific error for dir import
11cb078 
Fixes: nodejs#33219
guybedford pushed a commit that referenced this issue May 16, 2020
@aduh95 @guybedford
esm: improve commonjs hint on module not found
1cb80d1 
Adds hint when module specifier is a file URL.

PR-URL: #33220
Fixes: #33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
codebytere pushed a commit that referenced this issue May 16, 2020
@aduh95 @codebytere
module: add specific error for dir import
35aae31 
PR-URL: #33220
Fixes: #33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
codebytere pushed a commit that referenced this issue May 16, 2020
@aduh95 @codebytere
esm: improve commonjs hint on module not found
e53de96 
Adds hint when module specifier is a file URL.

PR-URL: #33220
Fixes: #33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
codebytere pushed a commit that referenced this issue Jun 7, 2020
@aduh95 @codebytere
module: add specific error for dir import
9cc7b24 
PR-URL: #33220
Fixes: #33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
codebytere pushed a commit that referenced this issue Jun 7, 2020
@aduh95 @codebytere
esm: improve commonjs hint on module not found
1c238b6 
Adds hint when module specifier is a file URL.

PR-URL: #33220
Fixes: #33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
codebytere pushed a commit to codebytere/node that referenced this issue Jun 9, 2020
@aduh95 @codebytere
module: add specific error for dir import
4f6e4ae 
PR-URL: nodejs#33220
Fixes: nodejs#33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
codebytere pushed a commit that referenced this issue Jun 9, 2020
@aduh95 @codebytere
esm: improve commonjs hint on module not found
a029dca 
Adds hint when module specifier is a file URL.

PR-URL: #33220
Fixes: #33219
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

module: add specific error for dir import aduh95/node
1 participant
@guybedford