Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New documentation lint rule #18703

Closed
BridgeAR opened this issue Feb 10, 2018 · 3 comments
Closed

New documentation lint rule #18703

BridgeAR opened this issue Feb 10, 2018 · 3 comments
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@BridgeAR
Copy link
Member

I personally would really like to add a 80 character limit to our linter for the docs.

maybe someone would like to tackle that? :-)
@BridgeAR BridgeAR added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. good first issue Issues that are suitable for first-time contributors. labels Feb 10, 2018
@BridgeAR
Copy link
Member Author

@watilde would you mind being a mentor in case that is needed?

@watilde
Copy link
Contributor

watilde commented Feb 10, 2018

Sure, I'd love to :)

@brianlmacdonald
Copy link

Can I call dibs on this?

@gideontee gideontee mentioned this issue Feb 12, 2018
Closed
4 tasks
@estrada9166 estrada9166 mentioned this issue Feb 12, 2018
Closed
3 tasks
MylesBorins pushed a commit that referenced this issue Mar 7, 2018
@estrada9166 @MylesBorins
doc: add new documentation rule
cde6671 
Add 80 characters limit to docs.
Change docs to fit 80 characters per row.

Backport-PR-URL: #19189
PR-URL: #18726
Fixes: #18703
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
targos pushed a commit to targos/node that referenced this issue Mar 24, 2018
@estrada9166 @targos
doc: add new documentation lint rule
5a57e4e 
Add 80 characters limit to docs.
Change docs to fit 80 characters per row.

PR-URL: nodejs#18726
Fixes: nodejs#18703
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@targos targos mentioned this issue Mar 24, 2018
Closed
targos pushed a commit that referenced this issue Mar 24, 2018
@estrada9166 @targos
doc: add new documentation rule
26e97a1 
Add 80 characters limit to docs.
Change docs to fit 80 characters per row.

Backport-PR-URL: #19189
PR-URL: #18726
Fixes: #18703
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this issue May 1, 2018
@estrada9166 @BridgeAR
doc: add new documentation lint rule
b0e2fd0 
Add 80 characters limit to docs.
Change docs to fit 80 characters per row.

PR-URL: nodejs#18726
Fixes: nodejs#18703
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
@estrada9166 @MayaLekova
doc: add new documentation lint rule
ec386ed 
Add 80 characters limit to docs.
Change docs to fit 80 characters per row.

PR-URL: nodejs#18726
Fixes: nodejs#18703
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: enforce max-line-length lint rule
doc: add new documentation lint rule
3 participants
@watilde @BridgeAR @brianlmacdonald