Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky "sequential/test-http-server-consumed-timeout" #14312

Closed
Trott opened this issue Jul 16, 2017 · 4 comments
Closed

investigate flaky "sequential/test-http-server-consumed-timeout" #14312

Trott opened this issue Jul 16, 2017 · 4 comments
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.

Comments

@Trott
Copy link
Member

Trott commented Jul 16, 2017 •
edited by refack
Loading

  • Version: v9.0.0-pre
  • Platform: vs2017,win2016 & rhel72-s390x
  • Subsystem: test

https://ci.nodejs.org/job/node-test-binary-windows/9855/RUN_SUBSET=1,VS_VERSION=vs2017,label=win2016/console

not ok 399 sequential/test-http-server-consumed-timeout
  ---
  duration_ms: 1.41
  severity: fail
  stack: |-
    assert.js:48
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: Request timeout should not fire
        at IncomingMessage.mustNotCall (c:\workspace\node-test-binary-windows\RUN_SUBSET\1\VS_VERSION\vs2017\label\win2016\test\common\index.js:563:12)
        at emitOne (events.js:115:13)
        at IncomingMessage.emit (events.js:210:7)
        at Socket.socketOnTimeout (_http_server.js:389:48)
        at emitNone (events.js:105:13)
        at Socket.emit (events.js:207:7)
        at Socket._onTimeout (net.js:402:8)
        at ontimeout (timers.js:469:11)
        at tryOnTimeout (timers.js:304:5)
        at Timer.listOnTimeout (timers.js:264:5)
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem. windows Issues and PRs related to the Windows platform. labels Jul 16, 2017
@refack refack removed the windows Issues and PRs related to the Windows platform. label Aug 13, 2017
@refack
Copy link
Contributor

refack commented Aug 13, 2017 •
edited
Loading

Showed up on linuxONE

not ok 1661 sequential/test-http-server-consumed-timeout
  ---
  duration_ms: 0.559
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: Request timeout should not fire
        at IncomingMessage.mustNotCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:560:12)
        at emitOne (events.js:115:13)
        at IncomingMessage.emit (events.js:210:7)
        at Socket.socketOnTimeout (_http_server.js:389:48)
        at emitNone (events.js:105:13)
        at Socket.emit (events.js:207:7)
        at Socket._onTimeout (net.js:400:8)
        at ontimeout (timers.js:469:11)
        at tryOnTimeout (timers.js:304:5)
        at Timer.listOnTimeout (timers.js:264:5)
  ...

https://ci.nodejs.org/job/node-test-commit-linuxone/7940/nodes=rhel72-s390x/console

Stress test indicate 0.1% failures - https://ci.nodejs.org/job/node-stress-single-test/1373/nodes=rhel72-s390x/

@refack refack changed the title investigate flaky sequential/test-http-server-consumed-timeout on Windows investigate flaky "sequential/test-http-server-consumed-timeout" Aug 13, 2017
@BridgeAR
Copy link
Member

@nodejs/testing are we just going to live with the test being flaky at times?

@Trott
Copy link
Member Author

Trott commented Sep 29, 2017

Because there's always a chance that a 25ms timeout will take longer than 200ms to actually be invoked, there's always going to be a chance that this test (as written) will fail spuriously. However, I think I see a way to reduce the frequency by an order of magnitude or two...

First, though, CI stress on current master to confirm we still have a measurable problem: https://ci.nodejs.org/job/node-stress-single-test/1427/nodes=rhel72-s390x/console

Trott added a commit to Trott/io.js that referenced this issue Sep 29, 2017
@Trott
test: skip test if host is too slow
f001398 
test-http-server-consumed-timeout will fail if the host is sufficiently
loaded that a 25ms interval takes more than 200ms to be invoked. Skip
the test in that situation.

Fixes: nodejs#14312
@Trott Trott mentioned this issue Sep 29, 2017
Closed
2 tasks
@Trott
Copy link
Member Author

Trott commented Sep 29, 2017

OK, I'm able to get it to 100% reliability as long as we're OK with skipping the test in unfavorable conditions. See #15688

@Trott Trott closed this as completed in a3cd8ed Oct 4, 2017
addaleax pushed a commit to addaleax/ayo that referenced this issue Oct 4, 2017
@Trott @addaleax
test: skip test if host is too slow
deeda3a 
test-http-server-consumed-timeout will fail if the host is sufficiently
loaded that a 25ms interval takes more than 200ms to be invoked. Skip
the test in that situation.

PR-URL: nodejs/node#15688
Fixes: nodejs/node#14312
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 7, 2017
@Trott @MylesBorins
test: skip test if host is too slow
1a0211a 
test-http-server-consumed-timeout will fail if the host is sufficiently
loaded that a 25ms interval takes more than 200ms to be invoked. Skip
the test in that situation.

PR-URL: #15688
Fixes: #14312
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 11, 2017
@Trott @MylesBorins
test: skip test if host is too slow
995948a 
test-http-server-consumed-timeout will fail if the host is sufficiently
loaded that a 25ms interval takes more than 200ms to be invoked. Skip
the test in that situation.

PR-URL: #15688
Fixes: #14312
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 17, 2017
@Trott @MylesBorins
test: skip test if host is too slow
019fa6c 
test-http-server-consumed-timeout will fail if the host is sufficiently
loaded that a 25ms interval takes more than 200ms to be invoked. Skip
the test in that situation.

PR-URL: #15688
Fixes: #14312
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 25, 2017
@Trott @MylesBorins
test: skip test if host is too slow
83a2513 
test-http-server-consumed-timeout will fail if the host is sufficiently
loaded that a 25ms interval takes more than 200ms to be invoked. Skip
the test in that situation.

PR-URL: #15688
Fixes: #14312
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: skip test if host is too slow Trott/io.js
3 participants
@refack @Trott @BridgeAR