-
Notifications
You must be signed in to change notification settings - Fork 30.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
test: increase coverage for worker_threads
Provide a test to cover adding setting `onmessage` to a non-function. This provides previously-missing coverage for an else block in the `onmessage` setter.
- Loading branch information
Showing
1 changed file
with
26 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
// When MessagePort.onmessage is set to a value that is not a function, the | ||
// setter should call .unref() and .stop(), clearing a previous onmessage | ||
// listener from holding the event loop open. This test confirms that | ||
// functionality. | ||
|
||
// Flags: --experimental-worker | ||
'use strict'; | ||
const common = require('../common'); | ||
const { Worker, parentPort } = require('worker_threads'); | ||
|
||
// Do not use isMainThread so that this test itself can be run inside a Worker. | ||
if (!process.env.HAS_STARTED_WORKER) { | ||
process.env.HAS_STARTED_WORKER = 1; | ||
const w = new Worker(__filename); | ||
w.postMessage(2); | ||
} else { | ||
// .onmessage uses a setter. Set .onmessage to a function that ultimately | ||
// should not be called. This will call .ref() and .start() which will keep | ||
// the event loop open (and prevent this from exiting) if the subsequent | ||
// assignment of a value to .onmessage doesn't call .unref() and .stop(). | ||
parentPort.onmessage = common.mustNotCall(); | ||
// Setting `onmessage` to a value that is not a function should clear the | ||
// previous value and also should allow the event loop to exit. (In other | ||
// words, this test should exit rather than run indefinitely.) | ||
parentPort.onmessage = 'fhqwhgads'; | ||
} |