fixup!: fix checks with V8_ENABLE_CHECKS

nodejs · Apr 19, 2021 · be59b67 · be59b67
1 parent 386f07b
commit be59b67
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js
@@ -152,10 +152,13 @@ function createOnGlobalUncaughtException() {
       try {
         const report = internalBinding('report');
         if (report != null && report.shouldReportOnUncaughtException()) {
-          report.writeReport(er ? er.message : 'Exception',
-                             'Exception',
-                             null,
-                             er ? er : {});
+          report.writeReport(
+            typeof er?.message === 'string' ?
+              er.message :
+              'Exception',
+            'Exception',
+            null,
+            er ? er : {});
         }
       } catch {}  // Ignore the exception. Diagnostic reporting is unavailable.
     }

diff --git a/src/node_report.cc b/src/node_report.cc
@@ -39,6 +39,7 @@ using node::TIME_TYPE;
 using node::worker::Worker;
 using v8::Array;
 using v8::Context;
+using v8::HandleScope;
 using v8::HeapSpaceStatistics;
 using v8::HeapStatistics;
 using v8::Isolate;
@@ -545,6 +546,7 @@ static void PrintJavaScriptErrorStack(JSONWriter* writer,
                                       Local<Value> error,
                                       const char* trigger) {
   TryCatch try_catch(isolate);
+  HandleScope scope(isolate);
   Local<Context> context = isolate->GetCurrentContext();
   std::string ss = "";
   if ((!strcmp(trigger, "FatalError")) ||

diff --git a/test/report/test-report-uncaught-exception-primitives.js b/test/report/test-report-uncaught-exception-primitives.js
@@ -17,6 +17,7 @@ process.on('uncaughtException', common.mustCall((err) => {
   assert.strictEqual(reports.length, 1);
   console.log(reports[0]);
   helper.validate(reports[0], [
+    ['header.event', 'Exception'],
     ['javascriptStack.message', `${exception}`],
   ]);
 }));

diff --git a/test/report/test-report-uncaught-exception-symbols.js b/test/report/test-report-uncaught-exception-symbols.js
@@ -17,6 +17,7 @@ process.on('uncaughtException', common.mustCall((err) => {
   assert.strictEqual(reports.length, 1);
   console.log(reports[0]);
   helper.validate(reports[0], [
+    ['header.event', 'Exception'],
     ['javascriptStack.message', 'Symbol(foobar)'],
   ]);
 }));