add tests

nodejs · Dec 20, 2022 · 9bb6248 · 9bb6248
1 parent 2751e68
commit 9bb6248
Show file tree

Hide file tree

Showing 6 changed files with 43 additions and 1 deletion.
diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -104,7 +104,7 @@ async function getReportersMap(reporters, destinations) {
     const destination = kBuiltinDestinations.get(destinations[i]) ?? createWriteStream(destinations[i]);
 
     // Load the test reporter passed to --test-reporter
-    let reporterPath = kBuiltinReporters.get(name) ?? name;
+    const reporterPath = kBuiltinReporters.get(name) ?? name;
     const { esmLoader } = require('internal/process/esm_loader');
     const { pathToFileURL } = require('internal/url');
     const file = isAbsolute(reporterPath) ? pathToFileURL(reporterPath).href : reporterPath;

diff --git a/test/fixtures/test-runner/node_modules/r-esm/index.mjs b/test/fixtures/test-runner/node_modules/r-esm/index.mjs
diff --git a/test/fixtures/test-runner/node_modules/r-esm/package.json b/test/fixtures/test-runner/node_modules/r-esm/package.json
diff --git a/test/fixtures/test-runner/node_modules/r/index.js b/test/fixtures/test-runner/node_modules/r/index.js
diff --git a/test/fixtures/test-runner/node_modules/r/package.json b/test/fixtures/test-runner/node_modules/r/package.json
diff --git a/test/parallel/test-runner-reporters.js b/test/parallel/test-runner-reporters.js
@@ -92,4 +92,22 @@ describe('node:test reporters', { concurrency: true }, () => {
       assert.strictEqual(child.stdout.toString(), `${filename} {"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}`);
     });
   });
+
+  it('should support a custom reporter from node_modules', async () => {
+    const child = spawnSync(process.execPath,
+                            ['--test', '--test-reporter', 'r', 'reporters.js'],
+                            { cwd: fixtures.path('test-runner') });
+    assert.strictEqual(child.stderr.toString(), '');
+    assert.strictEqual(child.stdout.toString(),
+                       'package: r{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}');
+  });
+
+  it('should support a custom ESM reporter from node_modules', async () => {
+    const child = spawnSync(process.execPath,
+                            ['--test', '--test-reporter', 'r-esm', 'reporters.js'],
+                            { cwd: fixtures.path('test-runner') });
+    assert.strictEqual(child.stderr.toString(), '');
+    assert.strictEqual(child.stdout.toString(),
+                       'package: r-esm{"test:start":5,"test:pass":2,"test:fail":3,"test:plan":3,"test:diagnostic":7}');
+  });
 });