url: replace deprecated substr() -> substring()

nodejs · Jan 23, 2024 · 879629c · 879629c
1 parent 880c90c
commit 879629c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/url.js b/lib/url.js
@@ -958,7 +958,8 @@ Url.prototype.resolveObject = function resolveObject(relative) {
     srcPath.unshift('');
   }
 
-  if (hasTrailingSlash && (srcPath.join('/').substr(-1) !== '/')) {
+  const srcPathSlashes = srcPath.join('/');
+  if (hasTrailingSlash && (srcPathSlashes.substring(srcPathSlashes.length - 1) !== '/')) {
     srcPath.push('');
   }
 
@@ -990,7 +991,7 @@ Url.prototype.resolveObject = function resolveObject(relative) {
     result.pathname = null;
     result.path = null;
   } else {
-    result.pathname = srcPath.join('/');
+    result.pathname = srcPathSlashes;
   }
 
   // To support request.http