squash: arguments

nodejs · Oct 28, 2017 · 78ebc37 · 78ebc37
1 parent 7befb1c
commit 78ebc37
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 1 deletion.
diff --git a/benchmark/util/format.js b/benchmark/util/format.js
@@ -21,6 +21,9 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, type }) {
+  // For testing, if supplied with an empty type, default to string.
+  type = type || 'string';
+
   const [first, second] = inputs[type];
 
   bench.start();

diff --git a/benchmark/util/inspect-array.js b/benchmark/util/inspect-array.js
@@ -18,6 +18,9 @@ function main({ n, len, type }) {
   var arr = Array(len);
   var i, opts;
 
+  // For testing, if supplied with an empty type, default to denseArray.
+  type = type || 'denseArray';
+
   switch (type) {
     case 'denseArray_showHidden':
       opts = { showHidden: true };

diff --git a/benchmark/util/type-check.js b/benchmark/util/type-check.js
@@ -35,6 +35,9 @@ const bench = common.createBenchmark(main, {
 });
 
 function main(conf) {
+  // For testing, if supplied with an empty type, default to ArrayBufferView.
+  conf.type = conf.type || 'ArrayBufferView';
+
   const util = process.binding('util');
   const types = require('internal/util/types');
 

diff --git a/test/parallel/test-benchmark-util.js b/test/parallel/test-benchmark-util.js
@@ -4,4 +4,11 @@ require('../common');
 
 const runBenchmark = require('../common/benchmark');
 
-runBenchmark('util', ['n=1']);
+runBenchmark('util',
+             ['argument=false',
+              'input=',
+              'method=Array',
+              'n=1',
+              'option=none',
+              'type=',
+              'version=native']);