test: remove common.PORT from http tests

nodejs · Jun 29, 2016 · 515db4c · 515db4c
1 parent dac16d8
commit 515db4c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/test/parallel/test-http-client-keep-alive-release-before-finish.js b/test/parallel/test-http-client-keep-alive-release-before-finish.js
@@ -4,16 +4,18 @@ const http = require('http');
 
 const server = http.createServer((req, res) => {
   res.end();
-}).listen(common.PORT, common.mustCall(() => {
+}).listen(0, common.mustCall(() => {
   const agent = new http.Agent({
     maxSockets: 1,
     keepAlive: true
   });
 
+  const port = server.address().port;
+
   const post = http.request({
     agent: agent,
     method: 'POST',
-    port: common.PORT,
+    port: port,
   }, common.mustCall((res) => {
     res.resume();
   }));
@@ -30,7 +32,7 @@ const server = http.createServer((req, res) => {
   http.request({
     agent: agent,
     method: 'GET',
-    port: common.PORT,
+    port: port,
   }, common.mustCall((res) => {
     server.close();
     res.connection.end();

diff --git a/test/parallel/test-http-no-read-no-dump.js b/test/parallel/test-http-no-read-no-dump.js
@@ -15,16 +15,18 @@ const server = http.createServer((req, res) => {
     res.end();
     onPause();
   });
-}).listen(common.PORT, common.mustCall(() => {
+}).listen(0, common.mustCall(() => {
   const agent = new http.Agent({
     maxSockets: 1,
     keepAlive: true
   });
 
+  const port = server.address().port;
+
   const post = http.request({
     agent: agent,
     method: 'POST',
-    port: common.PORT,
+    port: port,
   }, common.mustCall((res) => {
     res.resume();
 
@@ -43,7 +45,7 @@ const server = http.createServer((req, res) => {
   http.request({
     agent: agent,
     method: 'GET',
-    port: common.PORT,
+    port: port,
   }, common.mustCall((res) => {
     server.close();
     res.connection.end();