fixup!: fix checks with V8_ENABLE_CHECKS

nodejs · Apr 19, 2021 · 3504831 · 3504831
1 parent 386f07b
commit 3504831
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/lib/internal/process/execution.js b/lib/internal/process/execution.js
@@ -152,10 +152,13 @@ function createOnGlobalUncaughtException() {
       try {
         const report = internalBinding('report');
         if (report != null && report.shouldReportOnUncaughtException()) {
-          report.writeReport(er ? er.message : 'Exception',
-                             'Exception',
-                             null,
-                             er ? er : {});
+          report.writeReport(
+            typeof er?.message === 'string' ?
+              er.message :
+              'Exception',
+            'Exception',
+            null,
+            er ? er : {});
         }
       } catch {}  // Ignore the exception. Diagnostic reporting is unavailable.
     }

diff --git a/test/report/test-report-uncaught-exception-primitives.js b/test/report/test-report-uncaught-exception-primitives.js
@@ -17,6 +17,7 @@ process.on('uncaughtException', common.mustCall((err) => {
   assert.strictEqual(reports.length, 1);
   console.log(reports[0]);
   helper.validate(reports[0], [
+    ['header.event', 'Exception'],
     ['javascriptStack.message', `${exception}`],
   ]);
 }));

diff --git a/test/report/test-report-uncaught-exception-symbols.js b/test/report/test-report-uncaught-exception-symbols.js
@@ -17,6 +17,7 @@ process.on('uncaughtException', common.mustCall((err) => {
   assert.strictEqual(reports.length, 1);
   console.log(reports[0]);
   helper.validate(reports[0], [
+    ['header.event', 'Exception'],
     ['javascriptStack.message', 'Symbol(foobar)'],
   ]);
 }));