-
Notifications
You must be signed in to change notification settings - Fork 30.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This patch introduces a helper crypto.digest() that computes a digest from the input at one shot. This can be 20-50% faster than the object-based createHash() for smaller inputs that are hashed in one shot.
- Loading branch information
1 parent
3948b89
commit 114f2f9
Showing
8 changed files
with
185 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
'use strict'; | ||
|
||
const common = require('../common.js'); | ||
const { createHash, digest } = require('crypto'); | ||
const path = require('path'); | ||
const filepath = path.resolve(__dirname, '../../test/fixtures/snapshot/typescript.js'); | ||
const fs = require('fs'); | ||
const assert = require('assert'); | ||
|
||
const bench = common.createBenchmark(main, { | ||
length: [1000, 100_000], | ||
method: ['md5', 'sha1', 'sha256'], | ||
type: ['string', 'buffer'], | ||
n: [100_000, 1000], | ||
}, { | ||
combinationFilter: ({ length, n }) => { | ||
return length * n <= 100_000 * 1000; | ||
}, | ||
}); | ||
|
||
function main({ length, type, method, n }) { | ||
let data = fs.readFileSync(filepath); | ||
if (type === 'string') { | ||
data = data.toString().slice(0, length); | ||
} else { | ||
data = Uint8Array.prototype.slice.call(data, 0, length); | ||
} | ||
|
||
const hash = digest ? | ||
(method, input) => digest(method, input, 'hex') : | ||
(method, input) => createHash(method).update(input).digest('hex'); | ||
const array = []; | ||
for (let i = 0; i < n; i++) { | ||
array.push(null); | ||
} | ||
bench.start(); | ||
for (let i = 0; i < n; i++) { | ||
array[i] = hash(method, data); | ||
} | ||
bench.end(n); | ||
assert.strictEqual(typeof array[n - 1], 'string'); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
|
||
if (!common.hasCrypto) | ||
common.skip('missing crypto'); | ||
|
||
const assert = require('assert'); | ||
const crypto = require('crypto'); | ||
const fixtures = require('../common/fixtures'); | ||
const fs = require('fs'); | ||
|
||
const methods = crypto.getHashes(); | ||
assert(methods.length > 0); | ||
|
||
function test(input) { | ||
for (const method of methods) { | ||
for (const outputEncoding of ['buffer', 'hex', 'base64', undefined]) { | ||
const oldDigest = crypto.createHash(method).update(input).digest(outputEncoding || 'hex'); | ||
const newDigest = crypto.digest(method, input, outputEncoding); | ||
assert.deepStrictEqual(newDigest, oldDigest, | ||
`different result from ${method} with encoding ${outputEncoding}`); | ||
} | ||
} | ||
} | ||
|
||
const input = fs.readFileSync(fixtures.path('utf8_test_text.txt')); | ||
test(input); | ||
test(input.toString()); |