-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Write() after end() should raise an error? #8814
Comments
This appears to have been fixed. If you try the same thing in 0.11.14, you should see something like this:
|
@cjihrig yeah I get the same on v0.11.14 but either way, that was the docs for v0.10.33. My plan was to know if it's going to be fixed on v0.10 branch or if the docs are going to change. |
The relevant issue is #7477, and the PR is #8422. I'm not sure what the plans are for the 0.10 branch are. Since it's a behavior change, I would think just a documentation update would do. @misterdjules might be able to answer your question. |
@cjihrig @a0viedo I also agree that we should fix the documentation not to use @a0viedo Would you like to send a PR to fix the documentation? That would be very much appreciated! |
Currently there's an example using http.ServerResponse stream, which has a known bug and will not throw an error while writing after end(). Changed to a writable stream from fs which behaves as expected. fix nodejs#8814 Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
Currently there's an example using http.ServerResponse stream, which has a known bug and will not throw an error while writing after end(). Changed to a writable stream from fs which behaves as expected. Fixes nodejs/node-v0.x-archive#8814. PR-URL: #155 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brendan Ashworth <squirrelslikeacorns@gmail.com>
Currently there's an example using http.ServerResponse stream, which has a known bug and will not throw an error while writing after end(). Changed to a writable stream from fs which behaves as expected. fix nodejs#8814 Signed-off-by: Julien Gilli <julien.gilli@joyent.com>
I was browsing the docs and found this:
But, on branch v0.10, this code does nothing:
This is a known bug or an expected behavior?
The text was updated successfully, but these errors were encountered: