feat: automate creation of the first LTS release #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to `git node release` that marks the release being created as the transition from Current to LTS.
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
+ Coverage 82.29% 82.49% +0.19%
==========================================
Files 34 35 +1
Lines 1717 1742 +25
==========================================
+ Hits 1413 1437 +24
- Misses 304 305 +1
Continue to review full report at Codecov.
|
4 tasks
|
See https://gist.github.com/richardlau/17d87552525d4e05da1298163fdf7cb7 for a sample session (creating |
targos
reviewed
Oct 22, 2020
lib/prepare_release.js
Outdated
Comment on lines
273
to
276
| return await cli.prompt( | ||
| 'Enter the LTS code name for this release line:', | ||
| { questionType: 'input', noSeparator: true, defaultAnswer: '' } | ||
| ); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Add a link to https://github.com/nodejs/Release/blob/master/CODENAMES.md ?
Done.
|
14.15.0 (created using this PR in its current state) has now gone out. |
codebytere
approved these changes
Oct 27, 2020
targos
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to
git node releasethat marks the release beingcreated as the transition from Current to LTS.
cc @nodejs/releasers