Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support system proxy #408

Merged
merged 1 commit into from
Jun 5, 2020
Merged

feat: support system proxy #408

merged 1 commit into from
Jun 5, 2020

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Apr 28, 2020

FIxes #407

  • Support set proxy from git config --get https.proxy
  • Support set proxy from ncu-config

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   77.13%   77.13%           
=======================================
  Files          21       21           
  Lines        1496     1496           
=======================================
  Hits         1154     1154           
  Misses        342      342           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75abd3a...a478458. Read the comment docs.

Copy link

@limichange limichange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@himself65 himself65 marked this pull request as ready for review April 28, 2020 12:45
lib/request.js Outdated Show resolved Hide resolved
lib/proxy.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@codebytere
Copy link
Member

@himself65 can you rebase this?

@himself65

This comment has been minimized.

@codebytere codebytere requested a review from joyeecheung May 30, 2020 03:05
@codebytere codebytere merged commit c6697de into nodejs:master Jun 5, 2020
codebytere pushed a commit to codebytere/node-core-utils that referenced this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: system proxy support
5 participants