Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle #issuecomment-371266836 like strings in PR link #206

Closed
gibfahn opened this issue Mar 7, 2018 · 4 comments
Closed

Handle #issuecomment-371266836 like strings in PR link #206

gibfahn opened this issue Mar 7, 2018 · 4 comments
Labels
enhancement Things that enhances functionality, provided by node-core-utils feature request New features for node-core-utils

Comments

@gibfahn
Copy link
Member

gibfahn commented Mar 7, 2018

Often when you're going through your notifications, you end up with something on the end of the pull request URL, for example:

https://github.com/nodejs/node/pull/19201#issuecomment-371266836
https://github.com/nodejs/node/pull/19201#event-1509291051
https://github.com/nodejs/node/pull/19201/files
https://github.com/nodejs/node/pull/19201#pullrequestreview-102067476

If you run git node metadata https://github.com/nodejs/node/pull/19201#issuecomment-371266836 it just shows the help text.

It should be easy to adjust the regex to handle anything of the form

https://(?:www.)github.com/(\w\+)/(\w\+)/pull/([0-9]+).*

and just capture the three things you need (in ()).

Also https://www.github.com/nodejs/node/pull/19201 doesn't currently work.

@gibfahn gibfahn added enhancement Things that enhances functionality, provided by node-core-utils feature request New features for node-core-utils labels Mar 7, 2018
@gibfahn
Copy link
Member Author

gibfahn commented Mar 7, 2018

IDK what the difference between enhancement and feature request is, so I'll ad both 😁.

priyank-p added a commit to priyank-p/node-core-utils that referenced this issue Mar 8, 2018
@priyank-p
Copy link
Contributor

IDK what the difference between enhancement and feature request is, so I'll ad both 😁.

I added descriptions to some labels (including enhancements, and feature request), I might not be the best person to add those so maybe some else can add some descriptions :)

@gibfahn
Copy link
Member Author

gibfahn commented Mar 9, 2018

Just to add, it looks like you can't currently do git node land https://github.com/nodejs/node/pull/19130.

@priyank-p
Copy link
Contributor

priyank-p commented Mar 9, 2018

Just to add, it looks like you can't currently do git node land https://github.com/nodejs/node/pull/19130.

Can you open a new issue for this? I totally missed it.

johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Things that enhances functionality, provided by node-core-utils feature request New features for node-core-utils
Projects
None yet
Development

No branches or pull requests

2 participants