This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
src,test: fix V8 engine issues #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhorton
reviewed
Apr 22, 2018
| @@ -23,7 +23,6 @@ test-esm-loader-modulemap : SKIP | |||
| test-esm-main-lookup : SKIP | |||
| test-esm-named-exports : SKIP | |||
| test-esm-namespace : SKIP | |||
| test-esm-ok : SKIP | |||
There was a problem hiding this comment.
Was this test just removed?
There was a problem hiding this comment.
Looks like it was moved in fddcd62.
|
@jackhorton I occasionally like to run a V8 build of the node-chakracore code and make sure the tests all pass. This ensures that we keep compatibility with V8. All of these issues (minus the status file cleanup) were preventing the V8 build from passing successfully. |
a52421c to
13d33ff
Compare
|
Ran tests on Windows and Linux: No failures |
MSLaguana
approved these changes
Apr 23, 2018
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 23, 2018
* Remove gyp include that no longer exists upstream * Conditionally include `v8-debug.h` * Fix test failures for V8 engine * Remove status entries for missing tests PR-URL: nodejs#519 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
|
One more CI before landing, the last one had a bunch of benchmark test timeouts on macOS: https://ci.nodejs.org/job/chakracore-test-pull-request/243/ |
* Remove gyp include that no longer exists upstream * Conditionally include `v8-debug.h` * Fix test failures for V8 engine * Remove status entries for missing tests PR-URL: nodejs#519 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
added a commit
that referenced
this pull request
Apr 23, 2018
* Remove gyp include that no longer exists upstream * Conditionally include `v8-debug.h` * Fix test failures for V8 engine * Remove status entries for missing tests PR-URL: #519 Reviewed-By: Seth Brenith <sethb@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8-debug.hChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes