This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
chakrashim: fix internal promise behavior #471
Merged
+146
−201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSLaguana
approved these changes
Feb 20, 2018
3497b0f to
044aff8
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 20, 2018
`test-promise-internal-creation` was failing because of the `state` and `result` properties we were attaching to it. Moved those fields into the external object. This change also enables more promise tests. PR-URL: nodejs#471 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
`test-promise-internal-creation` was failing because of the `state` and `result` properties we were attaching to it. Moved those fields into the external object. This change also enables more promise tests. PR-URL: nodejs#471 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
044aff8 to
bafa0de
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 23, 2018
`test-promise-internal-creation` was failing because of the `state` and `result` properties we were attaching to it. Moved those fields into the external object. This change also enables more promise tests. PR-URL: nodejs#471 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
`test-promise-internal-creation` was failing because of the `state` and `result` properties we were attaching to it. Moved those fields into the external object. This change also enables more promise tests. PR-URL: nodejs#471 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
`test-promise-internal-creation` was failing because of the `state` and `result` properties we were attaching to it. Moved those fields into the external object. This change also enables more promise tests. PR-URL: nodejs#471 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com> Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-promise-internal-creationwas failing because of thestateandresultproperties we were attaching to it. Moved those fields intothe external object.
This change also enables more promise tests.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim, test