This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
test: add a new.target test to addons-napi #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to have #451 merged before CI will pass. |
|
|
||
| // this !== new.target since we are being invoked through super() | ||
| bool result; | ||
| NAPI_CALL(env, napi_strict_equals(env, newTargetArg, thisArg, &result)); |
There was a problem hiding this comment.
Is it worth also having an additional test where new.target === this?
There was a problem hiding this comment.
Yeah, it probably is. That would be a regular (non-super) construction case. I'll add one.
5479325 to
5b6fad2
Compare
|
Any reason why we wouldnt make this test upstream? |
|
@jackhorton We should take this one upstream. I split it into a separate commit so it would be easier. |
kfarnung
pushed a commit
that referenced
this pull request
Jan 17, 2018
N-API testing for new.target is lacking. Rectify this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N-API testing for
new.targetis lacking. Rectify this.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test