Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

build: fixing lint issues #253

Merged
merged 1 commit into from
May 23, 2017
Merged

build: fixing lint issues #253

merged 1 commit into from
May 23, 2017

Conversation

kfarnung
Copy link
Contributor

  • Moved the chakra_jslint set to the engine handler, as it stands it
    will only get invoked if the engine is passed specifically.
  • Fixed two jslint issues
  • Removed duplicate "inspector" from the "test-ci" handler
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, test

@kfarnung kfarnung self-assigned this May 22, 2017
@kfarnung kfarnung requested a review from kunalspathak May 22, 2017 18:48
kunalspathak
kunalspathak reviewed May 22, 2017
View reviewed changes
vcbuild.bat
@@ -141,7 +141,7 @@ if "%i18n_arg%"=="full-icu" set configure_flags=%configure_flags% --with-intl=fu
if "%i18n_arg%"=="small-icu" set configure_flags=%configure_flags% --with-intl=small-icu
if "%i18n_arg%"=="intl-none" set configure_flags=%configure_flags% --with-intl=none
if "%i18n_arg%"=="without-intl" set configure_flags=%configure_flags% --without-intl
if "%engine%"=="chakracore" set configure_flags=%configure_flags% --without-bundled-v8
if "%engine%"=="chakracore" set configure_flags=%configure_flags% --without-bundled-v8&set chakra_jslint=deps\chakrashim\lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8&set chakra_jslint=deps\chakrashim\lib [](start = 85, length = 39)

good catch. Will this trigger jslint for the shim on Ubuntu as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. So far there's nothing chakracore-specific in the Makefile that's used for Ubuntu. It's on my list of things to look at, but I haven't gotten a chance yet.

kunalspathak
kunalspathak reviewed May 22, 2017
View reviewed changes
test/parallel/test-vm-new-script-new-context.js
@@ -50,7 +50,7 @@ assert.throws(
common.engineSpecificMessage({
v8: /not defined/,
chakracore: /undefined or null/
}));
}));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably was from my yesterdays commit.

kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 22, 2017
@kfarnung
build: fixing lint issues
1f37f42 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 22, 2017
@kfarnung
build: fixing lint issues
d5c5b1f 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
@kfarnung
build: fixing lint issues
eb30926 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
@kfarnung
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/chakracore-test-pull-request/44/

I'm going to push anyway since the failures are contained and not related to this change. Doing one more local validation, then pushing.

@kfarnung kfarnung merged commit eb30926 into nodejs:xplat May 23, 2017
@kfarnung kfarnung deleted the lintfixes branch May 23, 2017 20:36
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 23, 2017
@kfarnung
build: fixing lint issues
d75d283 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 23, 2017
@kfarnung
build: fixing lint issues
4915525 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 23, 2017
@kfarnung
build: fixing lint issues
cef78bd 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 24, 2017
@kfarnung
build: fixing lint issues
bdcfd26 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 31, 2017
@kfarnung
build: fixing lint issues
6433d2f 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 31, 2017
@kfarnung
build: fixing lint issues
344d846 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request May 31, 2017
@kfarnung
build: fixing lint issues
e6215e2 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
kfarnung added a commit to kfarnung/node-chakracore that referenced this pull request Jun 5, 2017
@kfarnung
build: fixing lint issues
0089410 
* Moved the chakra_jslint set to the engine handler, as it stands it
  will only get invoked if the engine is passed specifically.
* Fixed two jslint issues
* Removed duplicate "inspector" from the "test-ci" handler

PR-URL: nodejs#253
Reviewed-By: Kunal Pathak <Kunal.Pathak@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@kfarnung kfarnung

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfarnung @kunalspathak